[Kimchi-devel] [PATCH 0/8 V3] Create a common function to generate guest disk XML

Aline Manera alinefm at linux.vnet.ibm.com
Thu Oct 30 12:26:12 UTC 2014


V2 -> V3:
- Create check_remote_disk_path() on model/utils.py to verify the necessity
  to convert hostname to IP

V1 -> V2:
- Make xmlutils/disk.py independent of model instances


Aline Manera (8):
  Move _get_storage_xml() to xmlutils/disk.py
  Move vmdisks.py functions to xmlutils/disk.py
  Remove 'bus' paramater from /vms/<name>/storages documentation
  Update get_disk_xml() to get the device same according to bus and
    index values
  Remove ignore_src parameter from get_disk_xml()
  Get disk type according to file path on get_disk_xml()
  Check QEMU stream DNS capability when attaching new disk to guest
  Update vmtemplate.py to use get_disk_xml() while generating CDROM XML

 docs/API.md                        |   1 -
 src/kimchi/model/storagevolumes.py |   8 +-
 src/kimchi/model/utils.py          |  19 ++++-
 src/kimchi/model/vmstorages.py     | 144 +++++++++------------------------
 src/kimchi/vmdisks.py              |  75 ------------------
 src/kimchi/vmtemplate.py           |  74 ++++++-----------
 src/kimchi/xmlutils/disk.py        | 158 +++++++++++++++++++++++++++++++++++++
 tests/test_model.py                |  11 ++-
 8 files changed, 248 insertions(+), 242 deletions(-)
 delete mode 100644 src/kimchi/vmdisks.py
 create mode 100644 src/kimchi/xmlutils/disk.py

-- 
1.9.3




More information about the Kimchi-devel mailing list