[Kimchi-devel] [PATCH 2/2] Storage volume upload: Change storagevolumes to AsyncCollection

[Crístian Viana]

On 02-09-2014 05:42, lvroyce at linux.vnet.ibm.com wrote:
> From: Royce Lv <lvroyce at linux.vnet.ibm.com>
>
> Because storage volume create will include upload and download,
> storagevolumes will not present before async task's finished.
> so change storage volumes to async collection.
>
> Signed-off-by: Royce Lv <lvroyce at linux.vnet.ibm.com>

Please, run "make check-local" to find formatting errors and fix them.
Also, run "sudo make check" and fix the tests which are broken due to 
this patch.

> -from kimchi.control.base import Collection, Resource
> +from kimchi.control.base import Collection, Resource, AsyncCollection

"AsyncCollection" should come before "Collection"

> -from kimchi.utils import kimchi_log
> +from kimchi.utils import kimchi_log, add_task
> +from kimchi.model.tasks import TaskModel

"kimchi.model.tasks" should come before "kimchi.utils", and "add_task" 
should come before "kimchi_log".