[Kimchi-devel] [PATCH] [Kimchi] Bug fix: Update UI according to changes on /networks API

Aline Manera alinefm at linux.vnet.ibm.com
Wed Dec 2 18:36:23 UTC 2015


The /networks API was updated to allow user creates Linux bridges besides
macvtap bridges.

But as the UI needs to be updated accordingly to add this option, Kimchi 2.0
will continue to use macvtap bridge as default.

This patch also fixes the issue while creating a brigded VLAN tagging.

Signed-off-by: Aline Manera <alinefm at linux.vnet.ibm.com>
---
 ui/js/src/kimchi.network.js          | 2 +-
 ui/js/src/kimchi.network_add_main.js | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ui/js/src/kimchi.network.js b/ui/js/src/kimchi.network.js
index 539010e..c1c1ebd 100644
--- a/ui/js/src/kimchi.network.js
+++ b/ui/js/src/kimchi.network.js
@@ -35,7 +35,7 @@ kimchi.initNetworkListView = function() {
                 in_use : data[i].in_use,
                 state : data[i].state === "active" ? "up" : "down"
             };
-            if (data[i].connection === "bridge") {
+            if (data[i].connection === "macvtap") {
                 network.type = kimchi.NETWORK_TYPE_BRIDGE;
             } else {
                 network.type = data[i].connection;
diff --git a/ui/js/src/kimchi.network_add_main.js b/ui/js/src/kimchi.network_add_main.js
index ea69421..c28c9ce 100644
--- a/ui/js/src/kimchi.network_add_main.js
+++ b/ui/js/src/kimchi.network_add_main.js
@@ -34,7 +34,7 @@ kimchi.startNetworkCreation = function() {
         connection: network.type
     };
     if (network.type === kimchi.NETWORK_TYPE_BRIDGE) {
-        data.connection = "bridge";
+        data.connection = "macvtap";
         data.interface = network.interface;
         if ($("#enableVlan").prop("checked")) {
             data.vlan_id = network.vlan_id;
-- 
2.5.0




More information about the Kimchi-devel mailing list