[Kimchi-devel] [Wok 1/2] Fix version error in RPM building

Aline Manera alinefm at linux.vnet.ibm.com
Thu Dec 10 18:18:56 UTC 2015


Hi Lucio,

That way the VERSION file will not be updated while running "make dist".
We can make that update more robust to do not fail when no tag is listed.

I will apply patch 2 by now.

Regards,
Aline Manera

On 07/12/2015 16:22, Lucio Correia wrote:
> This code is not necessary because version is already got
> by configure.ac code.
>
> Signed-off-by: Lucio Correia <luciojhc at linux.vnet.ibm.com>
> ---
>   Makefile.am | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 106a577..d78bb11 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -156,12 +156,8 @@ uninstall-local:
>   	$(RM) -rf $(DESTDIR)/etc/wok
>   	$(RM) $(DESTDIR)/etc/nginx/conf.d/wok.conf
>
> -VERSION:
> -	@if test -d .git; then                                \
> -		git describe --abbrev=0 > $@;                     \
> -	fi
>
> -.PHONY: deb install-deb rpm fedora-rpm suse-rpm ChangeLog VERSION
> +.PHONY: deb install-deb rpm fedora-rpm suse-rpm ChangeLog
>
>
>   clean-local:




More information about the Kimchi-devel mailing list