[Kimchi-devel] [PATCH V2] [Kimchi] Use correct gettext package for building

[Paulo Vital]

Reviewed-by: Paulo Vital <pvital at linux.vnet.ibm.com>


On 12/15/2015 05:30 PM, Lucio Correia wrote:
> The correct gettext package needs to be installed in each
> distro in order autogen does not show the following error
> messages:
> warning: macro 'AM_GNU_GETTEXT' not found in library
> warning: macro 'AM_GNU_GETTEXT_VERSION' not found in library
> 
> Signed-off-by: Lucio Correia <luciojhc at linux.vnet.ibm.com>
> ---
>  contrib/DEBIAN/control.in     | 1 +
>  contrib/kimchi.spec.fedora.in | 1 +
>  contrib/kimchi.spec.suse.in   | 1 +
>  docs/README.md                | 6 +++---
>  4 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/contrib/DEBIAN/control.in b/contrib/DEBIAN/control.in
> index 40e7727..a023455 100644
> --- a/contrib/DEBIAN/control.in
> +++ b/contrib/DEBIAN/control.in
> @@ -27,6 +27,7 @@ Depends: wok,
>           spice-html5,
>           python-magic
>  Build-Depends: xsltproc,
> +               gettext,
>                 python-lxml,
>                 python-dev,
>                 python-pip
> diff --git a/contrib/kimchi.spec.fedora.in b/contrib/kimchi.spec.fedora.in
> index ebf102c..a28ddab 100644
> --- a/contrib/kimchi.spec.fedora.in
> +++ b/contrib/kimchi.spec.fedora.in
> @@ -30,6 +30,7 @@ Requires:	iscsi-initiator-utils
>  Requires:	python-libguestfs
>  Requires:	libguestfs-tools
>  Requires:	python-magic
> +BuildRequires:	gettext-devel
>  BuildRequires:	libxslt
>  BuildRequires:	python-lxml
>  BuildRequires:	python-devel
> diff --git a/contrib/kimchi.spec.suse.in b/contrib/kimchi.spec.suse.in
> index 3cec7f4..f2f2880 100644
> --- a/contrib/kimchi.spec.suse.in
> +++ b/contrib/kimchi.spec.suse.in
> @@ -30,6 +30,7 @@ Requires:	open-iscsi
>  Requires:	python-libguestfs
>  Requires:	guestfs-tools
>  Requires:	python-magic
> +BuildRequires:	gettext-tools
>  BuildRequires:	libxslt-tools
>  BuildRequires:	python-lxml
>  BuildRequires:	python-devel
> diff --git a/docs/README.md b/docs/README.md
> index bdfbd81..dc58556 100644
> --- a/docs/README.md
> +++ b/docs/README.md
> @@ -48,7 +48,7 @@ Install Dependencies
> 
>  **For fedora and RHEL:**
> 
> -     $ sudo yum install wok libvirt-python libvirt \
> +     $ sudo yum install wok libvirt-python libvirt gettext-devel \
>                          libvirt-daemon-config-network python-imaging \
>                          qemu-kvm python-ethtool sos python-ipaddr \
>                          nfs-utils iscsi-initiator-utils pyparted \
> @@ -81,14 +81,14 @@ channel at RHN Classic or Red Hat Satellite.
>                             qemu-kvm python-parted python-ethtool sosreport \
>                             xsltproc python-ipaddr python-lxml open-iscsi \
>                             python-guestfs libguestfs-tools spice-html5 \
> -                           python-magic python-paramiko \
> +                           python-magic python-paramiko gettext \
> 
>      # These dependencies are only required if you want to run the tests:
>      $ sudo apt-get install pep8 pyflakes python-requests python-mock
> 
>  **For openSUSE:**
> 
> -    $ sudo zypper install wok libvirt-python libvirt \
> +    $ sudo zypper install wok libvirt-python libvirt gettext-tools \
>                            libvirt-daemon-config-network python-imaging \
>                            kvm python-ethtool python-ipaddr nfs-client \
>                            open-iscsi python-parted python-libguestfs \
>