[Kimchi-devel] [kimchi-devel][PATCH 0/2] Fix error usage of feature tests
lvroyce at linux.vnet.ibm.com
lvroyce at linux.vnet.ibm.com
Tue Feb 3 08:47:05 UTC 2015
From: Royce Lv <lvroyce at linux.vnet.ibm.com>
Feature tests depend on running kimchi server should not be used
in model tests, while coincidently, command
"qemu-io -r http://localhost:8080/images/icon-fedora.png -c 'read -v 0 512'"
return code is 0 so we cannot count on the return code.
This patch forces module usage without running kimchi server to return false,
and fixes testcase accordingly.
REF:
https://github.com/kimchi-project/kimchi/issues/579
https://github.com/kimchi-project/kimchi/issues/580
Royce Lv (2):
Avoid using server dependent feature tests when server not running
Fix wrong usage of feature tests
src/kimchi/model/featuretests.py | 5 ++++-
src/kimchi/utils.py | 8 ++++++++
tests/test_model.py | 16 +++++++---------
3 files changed, 19 insertions(+), 10 deletions(-)
--
1.9.3
More information about the Kimchi-devel
mailing list