[Kimchi-devel] [PATCH V2 2/2] UI: Sample of list widget

Wed Feb 4 15:00:46 UTC 2015

Few comments below...

On Wed Feb 04 2015 at 3:21:55 PM Wen Wang <wenwang at linux.vnet.ibm.com>
wrote:

> V1 -> V2:
> Add lincense and rename the sample file
>
> Signed-off-by: Wen Wang <wenwang at linux.vnet.ibm.com>
> ---
>  ui/js/widgets/samples/list.html | 45 ++++++++++++++++++++++++++++++
> +++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 ui/js/widgets/samples/list.html
>
> diff --git a/ui/js/widgets/samples/list.html b/ui/js/widgets/samples/list.
> html
> new file mode 100644
> index 0000000..286e941
> --- /dev/null
> +++ b/ui/js/widgets/samples/list.html
> @@ -0,0 +1,45 @@
> +<!--
> +/*
> + * Project Kimchi
> + *
> + * Copyright IBM, Corp. 2014
>

s/2014/2015

> + *
> + * Licensed under the Apache License, Version 2.0 (the 'License');
> + * you may not use this file except in compliance with the License.
> + * You may obtain a copy of the License at
> + *
> + *     http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an 'AS IS' BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> + -->
> +<!DOCTYPE html>
> +<html>
> +    <head>
> +        <meta charset="UTF-8">
> +        <title>Gauge Demo</title>
> +        <script src="../../../libs/jquery-1.10.0.min.js"></script>
> +        <script src="../../../libs/jquery-ui.min.js"></script>
> +        <script src="../list-flat.js"></script>
> +        <link rel="stylesheet" href="../../../libs/themes/
> base/jquery-ui.min.css">
> +        <link rel="stylesheet" href="../../../css/theme-
> default/list-flat.css">
> +        <link rel="stylesheet" href="../../../css/fontello/
> css/animation.css">
> +        <link rel="stylesheet" href="../../../css/fontello/
> css/fontello.css">
> +    </head>
> +    <body>
> +        <div class="list-demo"></div>
> +        <script>
> +            $(document).ready(function() {
> +                $(".list-demo").listFlat({
> +                    title: "Hello World"  //Set title.
> +                });
> +                $(".list-demo").listFlat("addItem", "Hello", "2015",
> "icon-user", "button1");
> +                        //Add one item of the list, parameters are: name,
> info, icon and button-id
>

Indentation of the comment is wrong - looks for me there's one more TAB.
Also, would be nice to place the comment before the operation.

> +            });
> +        </script>
> +    </body>
> +</html>
> \ No newline at end of file
> --
> 2.1.0
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20150204/f3a92758/attachment.html>