[Kimchi-devel] [PATCH v] Making urls relative

[Frédéric Bonnard]

From: Frederic Bonnard <frediz at linux.vnet.ibm.com>

On Wed, 11 Mar 2015 12:39:48 -0300, Aline Manera <alinefm at linux.vnet.ibm.com> wrote
> My point is: if the main idea behind it is to allow user to connects               
> > Kimchi to the external web server, why do not add an option to do it for           
> > > the user?                                                                          
> 2) Add an option to Kimchi config file to allow user connects to an                
> > external web server.                                                               

I'm a bit confused : do you mean, why don't we add an option so that kimchi starts nginx ?
If this is your question, in a distro we would have kimchi package have a dependency
on [nginx | apache]. So when you would install kimchi, it would install a web server as well
and distros usually starts all services once installed, so, nginx would be already started.
That is why, we would need an option, not to start the web server instead.
I'm not sure I got you point :) sorry.
In the same topic, that's why I'm using the patch in thread "RFC patch to make nginx proxy optional" [1]

> And yes - we launch nginx (if we should or not do that it is other
> > discussion) and we will continue doing that until something changes what
> > > is not in our plans by now.

I'm not willing to change that default :) . It'll just be nice to have an option to change
that behaviour in other environments [1]. Default would be as it already is, but we could
specify with that option to disable launching an external webserver or specify another one like apache.
as Royce suggested [2] ? 

Here follows the patch without the configuration file I put the previous time.

F.

1: http://lists.ovirt.org/pipermail/kimchi-devel/2015-February/009642.html
2: http://lists.ovirt.org/pipermail/kimchi-devel/2015-February/009655.html


Frederic Bonnard (1):
  Making urls relative

 src/kimchi/screenshot.py              |   2 +-
 ui/css/theme-default/template_add.css |  20 ++--
 ui/css/theme-default/topbar.css       |   2 +-
 ui/js/src/kimchi.api.js               | 176 +++++++++++++++++-----------------
 ui/js/src/kimchi.login.js             |   2 +-
 ui/pages/guest.html.tmpl              |   2 +-
 ui/pages/help/dita-help.xsl           |   4 +-
 ui/pages/kimchi-ui.html.tmpl          |   4 +-
 ui/pages/storagepool-add.html.tmpl    |   2 +-
 ui/pages/tabs/storage.html.tmpl       |   2 +-
 ui/pages/template-add.html.tmpl       |   2 +-
 11 files changed, 109 insertions(+), 109 deletions(-)

-- 
1.9.1