[Kimchi-devel] Issue #744

[Chandra Shehkhar Reddy Potula]

ok about issue #744.

I guess this issue not introduced after new plug in development. To 
explain in detail:

I downloaded the latest kimchi master and for testing I tried the following:
*Base folder level:*
  $cd kimchi
  $./autogen.sh --system
  $make
*
**To plugin level:*
$cd src/wok/plugins/kimchi
  $./autogen.sh --system
  $make

*Then at the base folder level ran the following command:*
[root at chandra kimchi]# sudo src/wokd --environment=dev
Plugin configuration file 
/run/media/chandra/8cf6e9d9-bd8d-4982-9d83-26760e0dd24e/workspace-python/kimchi/src/wok/plugins/ginger/ginger.conf 
doesn't exist.
Plugin configuration file 
/run/media/chandra/8cf6e9d9-bd8d-4982-9d83-26760e0dd24e/workspace-python/kimchi/src/wok/plugins/ginger/ginger.conf 
doesn't exist.
 > 
/run/media/chandra/8cf6e9d9-bd8d-4982-9d83-26760e0dd24e/workspace-python/kimchi/src/wok/plugins/kimchi/root.py(21)<module>()
-> import json
(Pdb) c
WARNING: no 'numpy' module, HyBi protocol will be slower
Traceback (most recent call last):
   File "src/wokd", line 101, in <module>
     sys.exit(main(sys.argv[1:]))
   File "src/wokd", line 98, in main
     wok.server.main(options)
   File 
"/run/media/chandra/8cf6e9d9-bd8d-4982-9d83-26760e0dd24e/workspace-python/kimchi/src/wok/server.py", 
line 205, in main
     srv = Server(options)
   File 
"/run/media/chandra/8cf6e9d9-bd8d-4982-9d83-26760e0dd24e/workspace-python/kimchi/src/wok/server.py", 
line 137, in __init__
     self._load_plugins(options)
   File 
"/run/media/chandra/8cf6e9d9-bd8d-4982-9d83-26760e0dd24e/workspace-python/kimchi/src/wok/server.py", 
line 160, in _load_plugins
     plugin_app = import_class(plugin_class)(options)
   File 
"/run/media/chandra/8cf6e9d9-bd8d-4982-9d83-26760e0dd24e/workspace-python/kimchi/src/wok/plugins/kimchi/root.py", 
line 39, in __init__
     self.model = kimchiModel.Model()
   File 
"/run/media/chandra/8cf6e9d9-bd8d-4982-9d83-26760e0dd24e/workspace-python/kimchi/src/wok/plugins/kimchi/model/model.py", 
line 45, in __init__
     self.objstore = ObjectStore(objstore_loc or config.get_object_store())
   File 
"/run/media/chandra/8cf6e9d9-bd8d-4982-9d83-26760e0dd24e/workspace-python/kimchi/src/wok/objectstore.py", 
line 91, in __init__
     self._init_db()
   File 
"/run/media/chandra/8cf6e9d9-bd8d-4982-9d83-26760e0dd24e/workspace-python/kimchi/src/wok/objectstore.py", 
line 94, in _init_db
     conn = self._get_conn()
   File 
"/run/media/chandra/8cf6e9d9-bd8d-4982-9d83-26760e0dd24e/workspace-python/kimchi/src/wok/objectstore.py", 
line 117, in _get_conn
     timeout=10)
sqlite3.OperationalError: unable to open database file

Since there is no folder (/var/lib/kimchi) where objectstore file 
creation happens, it fails with operational error. This due to the fact 
the Model class instantiated even before creating the directory where 
objectstore file will be created.

Fix requires in both Kimchi/Ginger Base plugins base class (root.py and 
gingerbase.py).

Also additionally I will go with option 2 for gingerbase plugin 
directory location.

Thanks and Regards
Chandra

On 10/28/2015 11:31 PM, Daniel Henrique Barboza wrote:
>
>
> On 10/28/2015 03:49 PM, Lucio Correia wrote:
>> On 28-10-2015 15:23, Chandra Shehkhar Reddy Potula wrote:
>>> Hi all,
>>>
>>> I need your input on the directory location (for debug reports and
>>> objectstore files) for new plugin gingerbase. Issue #744 is because of
>>> usage of /var/lib/kimchi directory.
>>>
>>> Kimchi uses the location /var/lib/kimchi for objectstore, isos,
>>> screenshots and so on...
>>>
>>> When I was coming up the new plugin gingerbase based on the inputs on
>>> below tickets, I tried to use same directory (/var/lib/kimchi) for the
>>> compatibility reasons.
>>> https://github.com/kimchi-project/kimchi/issues/721
>>> https://github.com/kimchi-project/kimchi/issues/738
>>>
>>> Now I feel that we should think about this carefully and pick the right
>>> location for objectstore and debug reports of new plugin gingerbase.
>>>
>>> I am thinking of two options here due to the fact that plugin kimchi
>>> instruction might destroy the path location /var/lib/kimchi
>>> 1. /var/lib/wok
>>> or
>>> 2. /var/lib/gingerbase
>>
>> Hi Chandra, option 2 is the best IMO. Each plugin should have its own 
>> place for data files.
>
> I agree with Lucio and Paulo. Go for option 2
>
>>
>>>
>>> Based on your inputs I will fix issue #744.
>>>
>>> Thanks and Regards
>>> Chandra
>>>
>>>
>>>
>>> _______________________________________________
>>> Kimchi-devel mailing list
>>> Kimchi-devel at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>>>
>>
>>
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20151029/bfabcf7f/attachment.html>