[Kimchi-devel] [PATCH][Wok] wokd service not comes up after reboot when enabled

[Aline Manera]

On 02/04/2016 10:41 AM, Daniel Henrique Barboza wrote:
>
>
> On 02/04/2016 10:33 AM, Chandra Shekhar Reddy Potula wrote:
>>
>>
>> On 04/02/16 5:56 PM, Chandra Shekhar Reddy Potula wrote:
>>>
>>>
>>> On 04/02/16 5:52 PM, Daniel Henrique Barboza wrote:
>>>>
>>>>
>>>> On 02/04/2016 09:58 AM, Aline Manera wrote:
>>>>>
>>>>>
>>>>> On 02/04/2016 09:09 AM, chandra at linux.vnet.ibm.com wrote:
>>>>>> From: Chandra Shekhar Reddy Potula <chandra at linux.vnet.ibm.com>
>>>>>>
>>>>>> Fixed Issue #31 : wokd service not comes up after reboot when 
>>>>>> enabled
>>>>>> ---
>>>>>>   contrib/wokd.service.fedora | 1 +
>>>>>>   1 file changed, 1 insertion(+)
>>>>>>
>>>>>> diff --git a/contrib/wokd.service.fedora 
>>>>>> b/contrib/wokd.service.fedora
>>>>>> index 33d88d8..68ae831 100644
>>>>>> --- a/contrib/wokd.service.fedora
>>>>>> +++ b/contrib/wokd.service.fedora
>>>>>> @@ -1,5 +1,6 @@
>>>>>>   [Unit]
>>>>>>   Description=Wok - Webserver Originated from Kimchi
>>>>>> +After=libvirtd.service
>>>>>
>>>>> Wok server does not depend on libvirtd service. It is a Kimchi 
>>>>> dependency and properly reported on kimchid service config file.
>>>>
>>>> If Chandra patch fixes this issue by adding this libvirtd 
>>>> condition, well, it means that we have
>>>> a flaw in the design of the plug-in dependencies + wok running as a 
>>>> service.
>>>>
>>>> Having the dependency in kimchid.service.fedora is of no avail if 
>>>> wokd.service.fedora isn't aware
>>>> of it. If there's no default way of making wokd aware of the 
>>>> dependencies of kimchid.service and
>>>> other dependencies of all the plug-ins, we'll need some sort of 
>>>> initialization script or something.
>>>>
>>> I totally agree with Daniel.
>>>
>>> I have not done extensive investigation but in reality some where we 
>>> are referring libvirt part of wokd.service and that has to be 
>>> corrected to make wokd service running with out a fail.
>>>
>> Ok, upon further look up, found file contrib/wokd.sysvinit contains 
>> the following:
>>
>> ### BEGIN INIT INFO
>> # Provides: wokd
>> # Required-Start: libvirtd
>> # Required-Stop:
>> # Default-Start: 3 5
>> # Default-Stop: 0 1 2 6
>> # Description: Start the wokd daemon
>> ### END INIT INFO
>
> This is a sysvinit file. Fedora uses systemd.
>
> And according to Aline's reply this libvirtd dependency shouldn't be 
> there either .... I
> think this is an impasse. We either remove all libvirtd dependencies 
> from WoK
> (including this one from sysvinit) or we allow the systemd file to 
> also have this
> libvirtd dependency (what Chandra's patch does). The design will need 
> to be
> revisited anyway. Question is: is it worth to leave wokd reboot broken in
> Fedora while the design is fixed?

WOW!

First of all, wok does not depend on any service, ie, this patch will 
not be accepted.

The contrib/wokd.sysvinit is legacy! No supported distribution uses it, 
ie, every distribution (Fedora 23, openSUSE 42.1, Ubuntu 15.10 and RHEL 
7.2) is using systemd.

Second, the contrib/kimchid.service.fedora is NOT legacy! It is there 
exactly to represent the kimchi dependency on libvirtd service.

If any other plugin has a service dependency it MUST create his own 
service file configuration - in the same way kimchi does.

Is kimchid.service not working as expected? I don't know! I haven't 
tested it carefully but if you know it is not, please, do a proper 
investigation on how systemd works and fix the kimchid.service file.

It was working before.

>>
>>
>>>>>
>>>>>>   [Service]
>>>>>>   Type=simple
>>>>>
>>>>> _______________________________________________
>>>>> Kimchi-devel mailing list
>>>>> Kimchi-devel at ovirt.org
>>>>> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>>>>>
>>>>
>>>> _______________________________________________
>>>> Kimchi-devel mailing list
>>>> Kimchi-devel at ovirt.org
>>>> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>>>>
>>>
>>> _______________________________________________
>>> Kimchi-devel mailing list
>>> Kimchi-devel at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>>>
>>
>> _______________________________________________
>> Kimchi-devel mailing list
>> Kimchi-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>