[Kimchi-devel] [Wok][PATCH 0/7] Multi-Culture Support

[Chandra Shekhar Reddy Potula]

Two suggestion overall if make sense.

1. why do we first of all provide locale in the underscore ('_') format 
and replace with hyphen ('-') ? Is there a reason behind this or will be 
good idea to use the locale strings with hyphen ('-') and no conversions 
all over.
2. method naming get_loc() and set_loc() could have been some thing like 
get_locale() and set_locale() to be more precise that these are for the 
locale settings. loc confused me with location :-)

On 5/4/16 2:40 PM, Chandra Shekhar Reddy Potula wrote:
> Reviewed-by: Chandra Shekhar Reddy Potula <chandra at linux.vnet.ibm.com>
>
> On 5/4/16 11:27 AM, pkulkark at linux.vnet.ibm.com wrote:
>> From: Pooja Kulkarni <pkulkark at linux.vnet.ibm.com>
>>
>> co-authored by: Archana Singh <archus at linux.vnet.ibm.com>
>>
>> This patch set provides multi-culture
>> support by adding another drop down
>> list during login for user locale
>> selection. The numeric data and datetime
>> fields are formatted based on the locale
>> selected.
>>
>> Pooja Kulkarni (7):
>>    Multi-Culture Support - Add a separate drop down list for locale
>>    Multi-Culture support - Add methods to get and set locales in
>>      wok.lang.js
>>    Multi-Culture support - Add locale in format settings in
>>      wok.line-chart.js
>>    Multi-Culture support : Format datetime as per locale in wok.list.js
>>    Multi-Culture support : Implement new drop down list for locale in
>>      wok.login.js
>>    Multi-Culture support : Modify wok.formatMeasurement util to include
>>      formatting based on locale
>>    Multi-Culture support : Format datetime in user activity log as per
>>      locale
>>
>>   ui/js/src/wok.lang.js       |  8 ++++++++
>>   ui/js/src/wok.line-chart.js |  3 ++-
>>   ui/js/src/wok.list.js       |  4 ++++
>>   ui/js/src/wok.login.js      |  9 +++++++++
>>   ui/js/src/wok.utils.js      | 10 +++++++---
>>   ui/js/wok.bootgrid.js       | 10 +++++++++-
>>   ui/js/wok.user-log.js       |  3 ++-
>>   ui/pages/login.html.tmpl    | 34 ++++++++++++++++++++++++++++++++++
>>   8 files changed, 75 insertions(+), 6 deletions(-)
>>
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>