[Kimchi-devel] [Wok][PATCH v2 1/7] Multi-Culture Support - Add a separate drop down list for locale

[Aline Manera]

On 05/05/2016 04:02 AM, pkulkark at linux.vnet.ibm.com wrote:
> From: Pooja Kulkarni <pkulkark at linux.vnet.ibm.com>
>
> co-authored by: Archana Singh <archus at linux.vnet.ibm.com>
>
> v2:
> Changed '_' to '-' in locale code list
>
> v1:
> This patch adds another drop down list
> for user locale selection. The list
> includes the 11 languages supported
> in UI plus a few extra languages
> for now (This will be extended later).
> By default, the locale will be the
> UI language selected.
>
> Signed-off-by: Pooja Kulkarni <pkulkark at linux.vnet.ibm.com>
> ---
>   ui/pages/login.html.tmpl | 34 ++++++++++++++++++++++++++++++++++
>   1 file changed, 34 insertions(+)
>
> diff --git a/ui/pages/login.html.tmpl b/ui/pages/login.html.tmpl
> index 411874b..0d49588 100644
> --- a/ui/pages/login.html.tmpl
> +++ b/ui/pages/login.html.tmpl
> @@ -119,6 +119,9 @@
>                               <span id="logging" style="display: none;">$_("Logging in...")</span>
>                           </button>
>                       </div>
> +                    <div id="">

Please, add an unique "id" for this <div>
It is useful when doing Selenium tests.

> +                    <dl>
> +                    <dt>
>                       <select id="userLang" class="selectpicker col-md-12 col-lg-12">
>                           <option value="en_US">English (US)</option>
>                           <option value="zh_CN">中文（简体）</option>
> @@ -132,6 +135,37 @@
>                           <option value="ru_RU">Русский (Россия)</option>
>                           <option value="zh_TW">中文（繁體）</option>
>                       </select>
> +                    </dt>
> +                    <dd><h3 style="margin-top:7px; margin-bottom:40px; color:grey">Language</h3></dd>
> +                    <dt>

Add translation support to "Language" label

> +                    <select id="userLocale" class="selectpicker col-md-12 col-lg-12">
> +                        <option value="af-NA">Afrikaans (Namibia)</option>
> +                        <option value="ar-DZ">Arabic (Algeria)</option>
> +                        <option value="az-AZ">Azerbaijani (Azerbaijan)</option>
> +                        <option value="en-US">English (US)</option>
> +                        <option value="hy-AM">Armenian (Armenia)</option>
> +                        <option value="hi-IN">Hindi (India)</option>
> +                        <option value="nl-BE">Dutch (Belgium)</option>
> +                        <option value="ms-MY">Malay (Malaysia)</option>
> +                        <option value="no-NO">Norwegian (Norway)</option>
> +                        <option value="sq-AL">Albanian (Albania)</option>
> +                        <option value="sv-SE">Swedish (Sweden)</option>
> +                        <option value="uz-UZ">Uzbek (Uzbekistan)</option>
> +                        <option value="zh-CN">中文（简体）</option>
> +                        <option value="pt-BR">Português (Brasil)</option>
> +                        <option value="de-DE">Deutsch (Deutschland)</option>
> +                        <option value="es-ES">Español (España)</option>
> +                        <option value="fr-FR">Français (France)</option>
> +                        <option value="it-IT">Italiano (Italia)</option>
> +                        <option value="ja-JP">日本語 (日本)</option>
> +                        <option value="ko-KR">한국어 (대한민국)</option>
> +                        <option value="ru-RU">Русский (Россия)</option>
> +                        <option value="zh-TW">中文（繁體）</option>
> +                    </select>
> +                    </dt>

> +                    <dd><h3 style="margin-top:7px; color:grey">Locale</dd>
> +                    </dl>

Same here.

> +                   </div>
>                   </form>
>               </div>
>               <div class="row">