[lago-devel] yapf and flake8 are running against each other - and my patch is in the middle.

Yaniv Kaul ykaul at redhat.com
Tue Nov 22 07:45:11 UTC 2016


Seems like there's a disagreement between yapf and flake on styling.
See
http://jenkins.ovirt.org/job/lago_master_check-patch-el7-x86_64/362/console
and
http://jenkins.ovirt.org/job/lago_master_check-patch-el7-x86_64/361/console
 :


*7:24:57* scripts/check_style.sh*07:24:57* yapf 0.7.1*07:25:59* ---
lago/templates.py	(original)*07:25:59* +++
lago/templates.py	(reformatted)*07:25:59* @@ -260,7 +260,6
@@*07:25:59*          finally:*07:25:59*
response.close()*07:25:59*  *07:25:59* -*07:25:59*  #: Registry for
template providers*07:25:59*  _PROVIDERS = {*07:25:59*      'file':
FileSystemTemplateProvider,*07:25:59* Yapf failed, make sure to
run:*07:25:59*     yapf --style .style.yapf --in-place --recursive .


vs.


*07:13:48* PYTHONPATH=/home/jenkins/workspace/lago_master_check-patch-el7-x86_64/lago
python /home/jenkins/workspace/lago_master_check-patch-el7-x86_64/lago/tests/venv/bin/flake8*07:13:52*
./lago/templates.py:264:1: E305 expected 2 blank lines after class or
function definition, found 1*07:13:52* make: *** [check-local] Error 1



Come on... I just want my patch in, it has nothing to do with this
supposed breakage.

Y.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/lago-devel/attachments/20161122/a477de49/attachment-0001.html>


More information about the lago-devel mailing list