[node-devel] Introduction and migration of the ovirt-node SysV init scripts to systemd

[Fabian Deutsch]

Am Mittwoch, den 15.02.2012, 15:44 -0500 schrieb Mike Burns:
> On Wed, 2012-02-15 at 21:27 +0100, Fabian Deutsch wrote:
> > A last step could be migrating the init scripts to python, in order to
> > consolidate some code.
> 
> Definitely important.  We currently have a number of functions in
> ovirt-functions (bash) and ovirtfunctions.py (python) that do the same
> thing.  Since the vast majority of the scripts are in python now,
> getting the init scripts to be python would allow us to deprecate the
> ovirt-functions script.  

Good to know, I did not yet take such a close look, but this sounds good
and is one more reason.

> > 
> > One problem I could imagine is, that the scripts currently export some
> > global variables and I don't to whom they will visible when using
> > systemd files - or if there is no change in the behavior at all.
> 
> I don't know of anywhere that we rely on the global variables.  In
> truth, any variables should be set in the /etc/default/ovirt file
> directly and sourced from there in other scripts.  

Right.

> > 
> > Does the migration and the suggested steps make sense? 
> > Or am I missing something?
> 
> The migration makes sense to me.  One thing to keep in mind on this is
> the fact that we have to continue to support RHEL which hasn't moved to
> systemd yet.  So having both the systemd and sysv init scripts around
> and running the same code in the background is also an important step.  

Yes, true. my suggestion would be to keep the "reduced" SysV init
scripts around which in turn call the appropriate bash or python scripts
providing the required functionality.

Thanks
fabian