[node-devel] Failed build node on F16 and F15

[Alan Pevec]

On Fri, Jun 29, 2012 at 10:42 AM, Fabian Deutsch <fabiand at redhat.com> wrote:
> Am Freitag, den 29.06.2012, 16:18 +0800 schrieb Eli Qiao:
>> I think the {_unitdir} are difference between F17 and F16&F15 , so I
>> give a ugly fix in ovirt-node.spec.in:
>>
>> %define is_f17 %(test "0%{?fedora}" == "017" && echo 1 || echo 0)
>> %if %is_f17
>> %else
>> %define _unitdir /usr/lib/systemd/system
>> %endif
>>
>> I can build it successfully , but I am not sure it is correct.
>
> That sounds reasonable, I wonder why systemd-units (which AFAIK defines
> _unitdir) isn't providing a different path on F15/F16.

F17 has that /usr-move feature, where all moved under /usr, it is
different on F16:
$ rpm -qf /etc/rpm/macros.systemd
systemd-units-37-25.fc16.x86_64
$ cat /etc/rpm/macros.systemd
%_unitdir /lib/systemd/system

The problem for F16 is in services/Makefile.am:
systemunitdir=$(prefix)/lib/systemd/system

so ovirt *.services end up in %{buildroot}/usr/lib/systemd/system/ on
both F16 and F17.
F16 systemd Makefile has: systemunitdir=$(rootdir)/lib/systemd/system
so you'd need some conditional in ovirt makefile if you want to
support building on both F16/17.

Cheers,
Alan