[node-devel] edit-node: mksquashfs failures on RHEL

[Charles_Rose at Dell.com]

Hello,

On RHEL 6.3, I attempted to add a package to ovirt-node-iso, but I get this trace. It looks like
mksquashfs osmin.img is being passed '-comp None':

# edit-node --install vim --repo ./rhel6.repo ovirt-node-iso-2.5.999-999.1.el6.iso
...
Creating Manifests
Copying Manifests
Editing Complete
...
_ovirt-node-iso: 15171/32768 files (0.8% non-contiguous), 105637/105637 blocks
['/sbin/mksquashfs', '/var/tmp/edit-liveos-2Rpc0f/iso/LiveOS/osmin',
'/var/tmp/edit-liveos-2Rpc0f/iso/LiveOS/osmin.img', '-comp', None]
Traceback (most recent call last):
  File "/usr/sbin/edit-node", line 1498, in <module>
    sys.exit(main())
  File "/usr/sbin/edit-node", line 1482, in main
    editor.package(output)
  File "/usr/lib/python2.6/site-packages/imgcreate/creator.py", line 768, in package
    self._stage_final_image()
  File "/usr/lib/python2.6/site-packages/imgcreate/live.py", line 302, in _stage_final_image
    create_image_minimizer(self.__isodir + "/LiveOS/osmin.img", self._image, self.compress_type)
  File "/usr/lib/python2.6/site-packages/imgcreate/fs.py", line 618, in create_image_minimizer
    mksquashfs(cowloop.lofile, path, compress_type)
  File "/usr/lib/python2.6/site-packages/imgcreate/fs.py", line 55, in mksquashfs
    ret = subprocess.call(args)
  File "/usr/lib64/python2.6/subprocess.py", line 478, in call
    p = Popen(*popenargs, **kwargs)
  File "/usr/lib64/python2.6/subprocess.py", line 639, in __init__
    errread, errwrite)
  File "/usr/lib64/python2.6/subprocess.py", line 1228, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

squashfs-tools-4.0 on RHEL does not support '-comp'. So I bumped it to squashfs-tools-4.2 from
upstream, still see the issue.

Based on imgcreate/fs.py, setting 'self.compress_type = gzip' in edit-node seems to work.

Is mksquashfs supposed to detect the compression type and use that? Any thoughts?

-- 
Thanks,
Charles Rose
Linux Engineering
Dell Inc.