From mburns at redhat.com Tue Jun 4 14:45:53 2013 From: mburns at redhat.com (Mike Burns) Date: Tue, 04 Jun 2013 10:45:53 -0400 Subject: [node-devel] oVirt Node Weekly Meeting Minutes -- 2013-06-04 Message-ID: <51ADFDA1.6050405@redhat.com> Minutes: http://ovirt.org/meetings/ovirt/2013/ovirt.2013-06-04-14.01.html Minutes (text): http://ovirt.org/meetings/ovirt/2013/ovirt.2013-06-04-14.01.txt Log: http://ovirt.org/meetings/ovirt/2013/ovirt.2013-06-04-14.01.log.html ================================= #ovirt: oVirt Node Weekly Meeting ================================= Meeting started by mburns at 14:01:07 UTC. The full logs are available at http://ovirt.org/meetings/ovirt/2013/ovirt.2013-06-04-14.01.log.html . Meeting summary --------------- * agenda (mburns, 14:01:20) * patch review (mburns, 14:01:32) * feature status (mburns, 14:01:35) * outstanding patches (mburns, 14:03:18) * 25 patches outstanding, some with acks that just need dependencies merged or rebasing (mburns, 14:04:17) * many patches around cleaning up old code (mburns, 14:05:00) * some draft and RFC patches that need updates (mburns, 14:05:22) * 6 patches have code review nacks that need action (mburns, 14:06:05) * ACTION: ALL -- review patches, update patches that need updates, nag people for reviews if your patches aren't being reviewed (mburns, 14:06:48) * Feature review (mburns, 14:09:37) * bridgeless network -- patches to be posted in next couple days (mburns, 14:09:52) * ACTION: fabiand to create bridgeless network feature page and test matrix (mburns, 14:14:08) * fabiand to link it to the oVirt 3.3 release page, node 3.0 release page, and engine feature page that it's related to (fabiand, 14:15:22) * patches for password/confirmation widget are coming today (mburns, 14:15:36) * tuned stuff is close, updated patches should be available in next couple days (mburns, 14:17:17) * log directory sync from iso to filesystem should also be updated in that timeframe (mburns, 14:18:07) * EL6 is close to working (mburns, 14:18:40) * EL6 needs a couple outstanding patches merged (dracut, urwid workarounds) (mburns, 14:19:03) * puppet patch is close, some comments and small tweaks needed (mburns, 14:26:51) Meeting ended at 14:43:49 UTC. Action Items ------------ * ALL -- review patches, update patches that need updates, nag people for reviews if your patches aren't being reviewed * fabiand to create bridgeless network feature page and test matrix Action Items, by person ----------------------- * fabiand * fabiand to create bridgeless network feature page and test matrix * **UNASSIGNED** * ALL -- review patches, update patches that need updates, nag people for reviews if your patches aren't being reviewed People Present (lines said) --------------------------- * mburns (73) * fabiand (59) * Yamaksi_ (6) * ovirtbot (5) * rbarry (3) * ewoud (1) * jboggs (1) * jvandewege (1) Generated by `MeetBot`_ 0.1.4 .. _`MeetBot`: http://wiki.debian.org/MeetBot From mburns at redhat.com Tue Jun 11 14:27:42 2013 From: mburns at redhat.com (Mike Burns) Date: Tue, 11 Jun 2013 10:27:42 -0400 Subject: [node-devel] oVirt Node Weekly Meeting Minutes -- 2013-06-11 Message-ID: <51B733DE.10907@redhat.com> Minutes: http://ovirt.org/meetings/ovirt/2013/ovirt.2013-06-11-14.00.html Minutes (text): http://ovirt.org/meetings/ovirt/2013/ovirt.2013-06-11-14.00.txt Log: http://ovirt.org/meetings/ovirt/2013/ovirt.2013-06-11-14.00.log.html ================================= #ovirt: oVirt Node Weekly Meeting ================================= Meeting started by mburns at 14:00:49 UTC. The full logs are available at http://ovirt.org/meetings/ovirt/2013/ovirt.2013-06-11-14.00.log.html . Meeting summary --------------- * agenda (mburns, 14:01:00) * patch review (mburns, 14:01:06) * 3.0 status updates (mburns, 14:01:12) * other topics (mburns, 14:01:15) * patch review (mburns, 14:03:14) * currest status -- 39 patches outstanding (mburns, 14:03:48) * 10 have nacks of some sort (mburns, 14:04:05) * 2 have code review +1 (mburns, 14:04:20) * ACTION: mburns to review/test el6 related patches today (mburns, 14:04:34) * other stats (mburns, 14:06:02) * 3 RFC patches (mburns, 14:06:10) * 5 draft patches (mburns, 14:06:19) * 1 don't commit patch (assuming that's for debugging...) (mburns, 14:06:41) * also, 1 patch posted for ovirt-node-iso repo to change repo list generation for iso builds (mburns, 14:07:36) * will now pull packages from ovirt.org/releases/node-base (mburns, 14:07:57) * so things like python-urwid that we need to temporarily override can be added there (mburns, 14:08:15) * topology patches close to being ready to review, fabiand to let us know when to test (mburns, 14:14:54) * 3.0 status update (mburns, 14:17:56) * new patch for puppet plugin posted yesterday (mburns, 14:18:16) * bridgeless network stuff close to ready (mburns, 14:18:44) * el6 support close to ready (mburns, 14:18:50) * centos builds will pull python-urwid from ovirt.org to get the current upstream for compatibility (mburns, 14:19:57) * ipv6 merged, just needs testing (mburns, 14:21:30) * all other features are complete (mburns, 14:21:45) * 2.6.x stream update (mburns, 14:22:40) * a new vdsm build will be coming out in the near future (mburns, 14:22:52) * we should post a new ovirt-node-iso to include this new vdsm (mburns, 14:23:04) * ACTION: fabiand post new ovirt-node iso image by EOW (mburns, 14:25:31) * other topics (mburns, 14:25:45) * nothing else (mburns, 14:26:55) Meeting ended at 14:26:59 UTC. Action Items ------------ * mburns to review/test el6 related patches today * fabiand post new ovirt-node iso image by EOW Action Items, by person ----------------------- * fabiand * fabiand post new ovirt-node iso image by EOW * mburns * mburns to review/test el6 related patches today * **UNASSIGNED** * (none) People Present (lines said) --------------------------- * mburns (50) * fabiand (10) * jboggs (6) * ovirtbot (4) * rbarry (1) Generated by `MeetBot`_ 0.1.4 .. _`MeetBot`: http://wiki.debian.org/MeetBot From fabiand at redhat.com Tue Jun 11 18:19:40 2013 From: fabiand at redhat.com (Fabian Deutsch) Date: Tue, 11 Jun 2013 20:19:40 +0200 Subject: [node-devel] Heads-Up: New network backend and supporting different "network topologies" Message-ID: <1370974780.4111.8.camel@fdeutsch-laptop.local> Hey, over the last days I've been working on our network backend code to allow different topologies (as requested by the oVirt Engine Team). The whole patch queue lives in the "topology" topic branch of gerrit. Basically the code should work as in, it can be used by the installer and setup to generate a valid network configuration. Brave souls out there can pick it up and start testing. But please don't expect to much yet. Bugs are hidden and to be found - remember it's a rewrite. As said, the backend code is merged - but the bridgeless code path is untested. Current testing focuses on stabilizing the "classic" bridge topology, once this stabilizes I'll be focusing in the "birdgeless" topology. The bridgeless-topology (or any topology selection) is not yet exposed in the UI, but supported in the backend. Once the code has been tested a bit more I'll be adding this feature to the UI. Expect more updates during the week. A nice side effect is that the code is now prepared (in some places) to be unit-testable. It also brings transactions to the auto-installer which shall help in the future to make the code cleaner. - fabian From fabiand at redhat.com Wed Jun 12 18:42:07 2013 From: fabiand at redhat.com (Fabian Deutsch) Date: Wed, 12 Jun 2013 20:42:07 +0200 Subject: [node-devel] Heads-Up: New network backend and supporting different "network topologies" In-Reply-To: <1370974780.4111.8.camel@fdeutsch-laptop.local> References: <1370974780.4111.8.camel@fdeutsch-laptop.local> Message-ID: <1371062527.2575.5.camel@fdeutsch-laptop.local> Am Dienstag, den 11.06.2013, 20:19 +0200 schrieb Fabian Deutsch: > over the last days I've been working on our network backend code to > allow different topologies (as requested by the oVirt Engine Team). > > The whole patch queue lives in the "topology" topic branch of gerrit. I've updated the topology branch and bug[0, 1]. All except two patches are now somewhat stable. Basically this patch queue results in an image which can create the basic networking configuration. There are still bugs and glitches. My suggestion is to review and merge all of the pending patches (except the DONTCOMMIT and DRAFT patches) and fix all upcoming bugs with follow up patches. I'm suggesting this path, because this is a bigger feature touching much and critical code, and the sooner it lands the more attention the code will get. Just some words regarding the remaining bugs: I plan to fix them with followup bugs, within the next week or so. Greetings fabian -- [0] https://bugzilla.redhat.com/show_bug.cgi?id=971410 [1] http://gerrit.ovirt.org/#/q/status:open+project:ovirt-node +branch:master+topic:topology,n,z From fabiand at redhat.com Fri Jun 14 09:12:17 2013 From: fabiand at redhat.com (Fabian Deutsch) Date: Fri, 14 Jun 2013 11:12:17 +0200 Subject: [node-devel] Action needed: Node's default network layout? Message-ID: <1371201137.2540.3.camel@fdeutsch-laptop.local> Hey, I've been working on allowing different network layouts in Node. Currently we allow two: bridged and NIC. bridged: The primary nic is the one and only slave of a bridge, and the bridge has all the IP configuration. direct: The primary nic has the IP configuration. 'briged' is our up to now default configuration. I suggest to switch to the "direct" layout by default. It's simple (less error prone) and gives consumers of Node the flexibility to do whatever they want with networking, without needing to take care of our existing bridge. What do you think? Greetings fabian From mburns at redhat.com Fri Jun 14 12:28:27 2013 From: mburns at redhat.com (Mike Burns) Date: Fri, 14 Jun 2013 08:28:27 -0400 Subject: [node-devel] Action needed: Node's default network layout? In-Reply-To: <1371201137.2540.3.camel@fdeutsch-laptop.local> References: <1371201137.2540.3.camel@fdeutsch-laptop.local> Message-ID: <51BB0C6B.8030508@redhat.com> On 06/14/2013 05:12 AM, Fabian Deutsch wrote: > Hey, > > I've been working on allowing different network layouts in Node. > Currently we allow two: bridged and NIC. > > bridged: > The primary nic is the one and only slave of a bridge, and the bridge > has all the IP configuration. > > direct: > The primary nic has the IP configuration. > > 'briged' is our up to now default configuration. I suggest to switch to > the "direct" layout by default. > It's simple (less error prone) and gives consumers of Node the > flexibility to do whatever they want with networking, without needing to > take care of our existing bridge. > > What do you think? The primary consumers of the ovirt-node model (oVirt and OpenStack) are both more interested in bridgeless than bridged these days, so I'd say we should make it bridgeless by default. I'll check with the only other consumer that I'm aware of (Archipel) to see if they have a preference. Mike > > Greetings > fabian > > _______________________________________________ > node-devel mailing list > node-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/node-devel > From fabiand at redhat.com Fri Jun 14 15:17:22 2013 From: fabiand at redhat.com (Fabian Deutsch) Date: Fri, 14 Jun 2013 17:17:22 +0200 Subject: [node-devel] Basic Bonding in Node Message-ID: <1371223042.31096.6.camel@fdeutsch-laptop.local> Hey, as I was working on the network stuff I also grabbed [0] and added some basic bonding support to Node [1]. The patches which currently live in the bond topic branch add the following features: - Initial creation of a bond device using kernel arguments - Bond device can be configured like any other NIC - Bond device management through the TUI Currently you can only create one bond device through the kargs or TUI. There is no technical reason for this, but IMO one bond is enough in the beginning and one bond fit's nicely into the UI. You will find one new button in the UI: - once you hit it a dialog appears where oyu can create a bond device. After the bond device was created all NICs which are part of the bond appear as "Configured" in the NIC list. Additionally the button changes from to (depending on the slaves of the bond). My idea is to either directly configure the bond when the user selects or display the bond device in the NIC list so it can be configured like any other device. The patches are open for discussion and not heavily tested. Greetings fabian -- [0] https://bugzilla.redhat.com/show_bug.cgi?id=831318 [1] http://www.ovirt.org/Features/Node/NIC_Bonding From mburns at redhat.com Mon Jun 17 17:06:26 2013 From: mburns at redhat.com (Mike Burns) Date: Mon, 17 Jun 2013 13:06:26 -0400 Subject: [node-devel] New networking setup stuff Message-ID: <51BF4212.7000909@redhat.com> Things look good so far, but some questions/issues that I found: Questions: Is there a way to toggle bridged/direct in the TUI? Issues: Error when de-activating nic with no bridge: 3/5 Write new configuration An error occurred while applying the changes: udev has no infos for None Nic Config transaction says "DNS and NTP configuration" this might be old/existing functionality Status screen shows "Bridge: eth0" not sure when this showed up so might be unrelated -- ovirt-node.log in /var/log From fabiand at redhat.com Mon Jun 17 19:34:09 2013 From: fabiand at redhat.com (Fabian Deutsch) Date: Mon, 17 Jun 2013 21:34:09 +0200 Subject: [node-devel] New networking setup stuff In-Reply-To: <51BF4212.7000909@redhat.com> References: <51BF4212.7000909@redhat.com> Message-ID: <1371497649.2709.10.camel@fdeutsch-laptop.local> Am Montag, den 17.06.2013, 13:06 -0400 schrieb Mike Burns: > Things look good so far, but some questions/issues that I found: > > Questions: > Is there a way to toggle bridged/direct in the TUI? Yep, I actually don't know the patch - maybe I need to reorganize it - but it's set in the NIC Details configuration, "Use bridge? [ ]" > > Issues: > > Error when de-activating nic with no bridge: > 3/5 Write new configuration > An error occurred while applying the changes: udev has no infos for None Yep, also ran into that one. > Nic Config transaction says "DNS and NTP configuration" this might be > old/existing functionality Yep, renamed it to "Basic Network Configuration", or maybe some other wording? > Status screen shows "Bridge: eth0" Yep, I removed the hard coded "Bridge", now geneirc network informations are shown. > not sure when this showed up so might be unrelated -- ovirt-node.log in > /var/log Yes, it should be there. Thanks for looking at it and your comments! I'll fix those issue in upcoming commits. - fabian From mburns at redhat.com Mon Jun 17 19:42:55 2013 From: mburns at redhat.com (Mike Burns) Date: Mon, 17 Jun 2013 15:42:55 -0400 Subject: [node-devel] New networking setup stuff In-Reply-To: <1371497649.2709.10.camel@fdeutsch-laptop.local> References: <51BF4212.7000909@redhat.com> <1371497649.2709.10.camel@fdeutsch-laptop.local> Message-ID: <51BF66BF.2000406@redhat.com> On 06/17/2013 03:34 PM, Fabian Deutsch wrote: > Am Montag, den 17.06.2013, 13:06 -0400 schrieb Mike Burns: >> Things look good so far, but some questions/issues that I found: >> >> Questions: >> Is there a way to toggle bridged/direct in the TUI? > > Yep, I actually don't know the patch - maybe I need to reorganize it - > but it's set in the NIC Details configuration, "Use bridge? [ ]" Unless i missed the patch, I'm not seeing this. I did checkout of this patch, rebased on top of latest git, and built: http://gerrit.ovirt.org/#/c/15700/ > >> >> Issues: >> >> Error when de-activating nic with no bridge: >> 3/5 Write new configuration >> An error occurred while applying the changes: udev has no infos for None > > Yep, also ran into that one. > >> Nic Config transaction says "DNS and NTP configuration" this might be >> old/existing functionality > > Yep, renamed it to "Basic Network Configuration", or maybe some other > wording? NIC Configuration or Network Interface Configuration > >> Status screen shows "Bridge: eth0" > > Yep, I removed the hard coded "Bridge", now geneirc network informations > are shown. > ACK >> not sure when this showed up so might be unrelated -- ovirt-node.log in >> /var/log > > Yes, it should be there. Can you tell me what is in which log? ovirt.log ovirt-debug.log ovirt-node.log And can/should we consolidate? Mike > > Thanks for looking at it and your comments! I'll fix those issue in > upcoming commits. > > - fabian > From fabiand at redhat.com Mon Jun 17 19:54:19 2013 From: fabiand at redhat.com (Fabian Deutsch) Date: Mon, 17 Jun 2013 21:54:19 +0200 Subject: [node-devel] New networking setup stuff In-Reply-To: <51BF66BF.2000406@redhat.com> References: <51BF4212.7000909@redhat.com> <1371497649.2709.10.camel@fdeutsch-laptop.local> <51BF66BF.2000406@redhat.com> Message-ID: <1371498859.2709.13.camel@fdeutsch-laptop.local> Am Montag, den 17.06.2013, 15:42 -0400 schrieb Mike Burns: > On 06/17/2013 03:34 PM, Fabian Deutsch wrote: > > Am Montag, den 17.06.2013, 13:06 -0400 schrieb Mike Burns: > >> Things look good so far, but some questions/issues that I found: > >> > >> Questions: > >> Is there a way to toggle bridged/direct in the TUI? > > > > Yep, I actually don't know the patch - maybe I need to reorganize it - > > but it's set in the NIC Details configuration, "Use bridge? [ ]" > > Unless i missed the patch, I'm not seeing this. I did checkout of this > patch, rebased on top of latest git, and built: > > http://gerrit.ovirt.org/#/c/15700/ I fixed it up in one of the bond related patches. > > > > >> > >> Issues: > >> > >> Error when de-activating nic with no bridge: > >> 3/5 Write new configuration > >> An error occurred while applying the changes: udev has no infos for None > > > > Yep, also ran into that one. > > > >> Nic Config transaction says "DNS and NTP configuration" this might be > >> old/existing functionality > > > > Yep, renamed it to "Basic Network Configuration", or maybe some other > > wording? > > NIC Configuration or Network Interface Configuration ack > > > >> Status screen shows "Bridge: eth0" > > > > Yep, I removed the hard coded "Bridge", now geneirc network informations > > are shown. > > > > ACK > > >> not sure when this showed up so might be unrelated -- ovirt-node.log in > >> /var/log > > > > Yes, it should be there. > > Can you tell me what is in which log? > > ovirt.log > ovirt-debug.log > ovirt-node.log > > And can/should we consolidate? Ah, now I see your point. ovirt.log - our legacy logfile, it will stay around until we migrated all legacy code. ovirt-debug.log - debug level logger ovirt-node.log - info level logger (much much less informations) On the long run ovirt.log and ovirt-node.log will be "merged", ovirt-node.debug.log can be disabled, maybe we can add a fag to enable it .. Fabian > > Mike > > > > Thanks for looking at it and your comments! I'll fix those issue in > > upcoming commits. > > > > - fabian > > > From mburns at redhat.com Mon Jun 17 20:07:28 2013 From: mburns at redhat.com (Mike Burns) Date: Mon, 17 Jun 2013 16:07:28 -0400 Subject: [node-devel] New networking setup stuff In-Reply-To: <1371498859.2709.13.camel@fdeutsch-laptop.local> References: <51BF4212.7000909@redhat.com> <1371497649.2709.10.camel@fdeutsch-laptop.local> <51BF66BF.2000406@redhat.com> <1371498859.2709.13.camel@fdeutsch-laptop.local> Message-ID: <51BF6C80.5010207@redhat.com> On 06/17/2013 03:54 PM, Fabian Deutsch wrote: > Am Montag, den 17.06.2013, 15:42 -0400 schrieb Mike Burns: >> On 06/17/2013 03:34 PM, Fabian Deutsch wrote: >>> Am Montag, den 17.06.2013, 13:06 -0400 schrieb Mike Burns: >>>> Things look good so far, but some questions/issues that I found: >>>> >>>> Questions: >>>> Is there a way to toggle bridged/direct in the TUI? >>> >>> Yep, I actually don't know the patch - maybe I need to reorganize it - >>> but it's set in the NIC Details configuration, "Use bridge? [ ]" >> >> Unless i missed the patch, I'm not seeing this. I did checkout of this >> patch, rebased on top of latest git, and built: >> >> http://gerrit.ovirt.org/#/c/15700/ > > I fixed it up in one of the bond related patches. > >> >>> >>>> >>>> Issues: >>>> >>>> Error when de-activating nic with no bridge: >>>> 3/5 Write new configuration >>>> An error occurred while applying the changes: udev has no infos for None >>> >>> Yep, also ran into that one. >>> >>>> Nic Config transaction says "DNS and NTP configuration" this might be >>>> old/existing functionality >>> >>> Yep, renamed it to "Basic Network Configuration", or maybe some other >>> wording? >> >> NIC Configuration or Network Interface Configuration > > ack > >>> >>>> Status screen shows "Bridge: eth0" >>> >>> Yep, I removed the hard coded "Bridge", now geneirc network informations >>> are shown. >>> >> >> ACK >> >>>> not sure when this showed up so might be unrelated -- ovirt-node.log in >>>> /var/log >>> >>> Yes, it should be there. >> >> Can you tell me what is in which log? >> >> ovirt.log >> ovirt-debug.log >> ovirt-node.log >> >> And can/should we consolidate? > > Ah, now I see your point. > ovirt.log - our legacy logfile, it will stay around until we migrated > all legacy code. > > ovirt-debug.log - debug level logger > ovirt-node.log - info level logger (much much less informations) > > On the long run ovirt.log and ovirt-node.log will be "merged", > ovirt-node.debug.log can be disabled, maybe we can add a fag to enable > it .. Ok, that makes some sense. I think making debug mode configurable makes sense, though if we do that, we could drop ovirt-debug.log completely, I think and just have debug logs go into the main log file. That way, we log just info in the ovirt-node.log file and only log debug if the configuration is set to enable debugging. Mike > > Fabian > >> >> Mike >>> >>> Thanks for looking at it and your comments! I'll fix those issue in >>> upcoming commits. >>> >>> - fabian >>> >> > > > _______________________________________________ > node-devel mailing list > node-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/node-devel > From bohai at huawei.com Fri Jun 21 04:05:56 2013 From: bohai at huawei.com (Bohai (ricky)) Date: Fri, 21 Jun 2013 04:05:56 +0000 Subject: [node-devel] support directly specify cdrom device to start livcd Message-ID: <98B730463BF8F84A885ABF3A8F6149515775964E@szxeml523-mbx.china.huawei.com> Hi: Now overt node only support to start livecd by specifing CDLABEL. Like this: root=live:CDLABEL=node-image But do not support to directly specify the cdrom device. Like this: root=live:/dev/sr0 This improve aims to support it. diff --git a/src/ovirtnode/ovirtfunctions.py b/src/ovirtnode/ovirtfunctions.py index 4285757..4b27b68 100644 --- a/src/ovirtnode/ovirtfunctions.py +++ b/src/ovirtnode/ovirtfunctions.py @@ -465,14 +465,19 @@ def mount_live(): # /dev/live if not exist alternative client = gudev.Client(['block']) cmdline = open("/proc/cmdline") - cdlabel = re.search('CDLABEL\=([a-zA-Z0-9_\.-]+)', cmdline.read()) - cdlabel = cdlabel.group(0).split("=")[1] - cmdline.close() - for device in client.query_by_subsystem("block"): - if device.has_property("ID_CDROM"): - dev = device.get_property("DEVNAME") - if system("blkid '%s'|grep -q '%s'" % (dev, cdlabel)): - live_dev = dev + cmdline_data = cmdline.read() + cdlabel = re.search('CDLABEL\=([a-zA-Z0-9_\.-]+)', cmdline_data) + if cdlabel is None: + cdlabel = re.search('live\:([a-zA-Z0-9_\.-\/]+)', cmdline_data) + live_dev = cdlabel.group(0).split(":")[1] + else: + cdlabel = cdlabel.group(0).split("=")[1] + cmdline.close() + for device in client.query_by_subsystem("block"): + if device.has_property("ID_CDROM"): + dev = device.get_property("DEVNAME") + if system("blkid '%s'|grep -q '%s'" % (dev, cdlabel)): + live_dev = dev except: pass if not live_dev: bohai(ricky) boh.ricky at gmail.com From bohai at huawei.com Fri Jun 21 06:37:20 2013 From: bohai at huawei.com (Bohai (ricky)) Date: Fri, 21 Jun 2013 06:37:20 +0000 Subject: [node-devel] fix no key "OVIRT_BOOTPARAMS" problem occured in ovirt-node's install Message-ID: <98B730463BF8F84A885ABF3A8F6149515776446A@szxeml523-mbx.china.huawei.com> Hi, I found the "No key" exception occurred in overt-node's install progress. For the detail, please see the attached picture. This patch fixs the problem. I am a newbie for ovirt-node and I apologize if I am missing something very obvious. Any advice is welcomed. diff --git a/src/ovirtnode/install.py b/src/ovirtnode/install.py index 7b95b04..eae26ba 100755 --- a/src/ovirtnode/install.py +++ b/src/ovirtnode/install.py @@ -475,7 +475,8 @@ initrd /initrd0.img else: self.root_param = "root=live:LABEL=Root" self.bootparams = "ro rootfstype=auto rootflags=ro " - self.bootparams += OVIRT_VARS["OVIRT_BOOTPARAMS"].replace( + + self.bootparams += OVIRT_VARS.get("OVIRT_BOOTPARAMS", "").replace( "console=tty0", "") if " " in self.disk or os.path.exists("/dev/cciss"): # workaround for grub setup failing with spaces in dev.name: bohai(ricky) boh.ricky at gmail.com -------------- next part -------------- A non-text attachment was scrubbed... Name: percent80.png Type: image/png Size: 17237 bytes Desc: percent80.png URL: From bohai at huawei.com Fri Jun 21 07:07:33 2013 From: bohai at huawei.com (Bohai (ricky)) Date: Fri, 21 Jun 2013 07:07:33 +0000 Subject: [node-devel] Question about the plugins page in ovirt config Message-ID: <98B730463BF8F84A885ABF3A8F6149515776454A@szxeml523-mbx.china.huawei.com> Hi, David Huff I have some question about plugins page. First, it seem no any plugins. Where can i get some document about how to use the page? I hope to know how to install plugins for ovirt config? Two, I try to press button "RPM diff", "SRPM diff", "File diff". The program crashed for the reason "Keyerror(' plugin'). Whether the feature is not finished now ?If so, can you tell me the plan about the feature. Best regard to you. bohai(ricky) boh.ricky at gmail.com -------------- next part -------------- A non-text attachment was scrubbed... Name: plugins_error.PNG Type: image/png Size: 3682 bytes Desc: plugins_error.PNG URL: From fabiand at redhat.com Fri Jun 21 07:31:46 2013 From: fabiand at redhat.com (Fabian Deutsch) Date: Fri, 21 Jun 2013 09:31:46 +0200 Subject: [node-devel] Question about the plugins page in ovirt config In-Reply-To: <98B730463BF8F84A885ABF3A8F6149515776454A@szxeml523-mbx.china.huawei.com> References: <98B730463BF8F84A885ABF3A8F6149515776454A@szxeml523-mbx.china.huawei.com> Message-ID: <1371799906.2619.6.camel@fdeutsch-laptop.local> Hey Bohai (or ricky?), Am Freitag, den 21.06.2013, 07:07 +0000 schrieb Bohai (ricky): > I have some question about plugins page. > First, it seem no any plugins. Where can i get some document about how to use the page? > I hope to know how to install plugins for ovirt config? The feature page can be found here: http://www.ovirt.org/Node_plugins Because edit-node changed a bit over time it could be that some commands are outdate. What kind of plugin do you want to install? > Two, I try to press button "RPM diff", "SRPM diff", "File diff". > The program crashed for the reason "Keyerror(' plugin'). That could be a bug. What version of oVirt Node are you using? And could you attach /var/log/ovirt.log and /tmp/ovirt.debug.log > Whether the feature is not finished now ?If so, can you tell me the plan about the feature. The plugin feature is now merged for some time and also used by us (e.g. to add the plugin for test automation). The UI for plugins is quite new and can still have some rough edges. Greetings fabian > Best regard to you. > > bohai(ricky) > boh.ricky at gmail.com > > > _______________________________________________ > node-devel mailing list > node-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/node-devel From fabiand at redhat.com Fri Jun 21 07:33:18 2013 From: fabiand at redhat.com (Fabian Deutsch) Date: Fri, 21 Jun 2013 09:33:18 +0200 Subject: [node-devel] fix no key "OVIRT_BOOTPARAMS" problem occured in ovirt-node's install In-Reply-To: <98B730463BF8F84A885ABF3A8F6149515776446A@szxeml523-mbx.china.huawei.com> References: <98B730463BF8F84A885ABF3A8F6149515776446A@szxeml523-mbx.china.huawei.com> Message-ID: <1371799998.2619.8.camel@fdeutsch-laptop.local> Hey Bohai (or ricky?), Am Freitag, den 21.06.2013, 06:37 +0000 schrieb Bohai (ricky): > I found the "No key" exception occurred in overt-node's install progress. > For the detail, please see the attached picture. The patch below looks quite okay, but could you also explain what you did to run into this problem? The kernel arguments and installation method would be interesting. Thanks fabian > This patch fixs the problem. > > I am a newbie for ovirt-node and I apologize if I am missing something very obvious. > Any advice is welcomed. > > > diff --git a/src/ovirtnode/install.py b/src/ovirtnode/install.py > index 7b95b04..eae26ba 100755 > --- a/src/ovirtnode/install.py > +++ b/src/ovirtnode/install.py > @@ -475,7 +475,8 @@ initrd /initrd0.img > else: > self.root_param = "root=live:LABEL=Root" > self.bootparams = "ro rootfstype=auto rootflags=ro " > - self.bootparams += OVIRT_VARS["OVIRT_BOOTPARAMS"].replace( > + > + self.bootparams += OVIRT_VARS.get("OVIRT_BOOTPARAMS", "").replace( > "console=tty0", "") > if " " in self.disk or os.path.exists("/dev/cciss"): > # workaround for grub setup failing with spaces in dev.name: > > bohai(ricky) > boh.ricky at gmail.com > > > _______________________________________________ > node-devel mailing list > node-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/node-devel From fabiand at redhat.com Fri Jun 21 07:41:49 2013 From: fabiand at redhat.com (Fabian Deutsch) Date: Fri, 21 Jun 2013 09:41:49 +0200 Subject: [node-devel] support directly specify cdrom device to start livcd In-Reply-To: <98B730463BF8F84A885ABF3A8F6149515775964E@szxeml523-mbx.china.huawei.com> References: <98B730463BF8F84A885ABF3A8F6149515775964E@szxeml523-mbx.china.huawei.com> Message-ID: <1371800509.2619.12.camel@fdeutsch-laptop.local> Hey Ricky, Am Freitag, den 21.06.2013, 04:05 +0000 schrieb Bohai (ricky): > Now overt node only support to start livecd by specifing CDLABEL. > Like this: > root=live:CDLABEL=node-image > > But do not support to directly specify the cdrom device. > Like this: > root=live:/dev/sr0 > > This improve aims to support it. Thanks for the patch! That's probably something others are interested in too. Could you push your patch (and the other one) to the ovirt-node project on our gerrit instance (http://gerrit.ovirt.org)? This wiki page explains how to work with gerrit: http://www.ovirt.org/Working_with_oVirt_Gerrit Thanks fabian > > > diff --git a/src/ovirtnode/ovirtfunctions.py b/src/ovirtnode/ovirtfunctions.py > index 4285757..4b27b68 100644 > --- a/src/ovirtnode/ovirtfunctions.py > +++ b/src/ovirtnode/ovirtfunctions.py > @@ -465,14 +465,19 @@ def mount_live(): > # /dev/live if not exist alternative > client = gudev.Client(['block']) > cmdline = open("/proc/cmdline") > - cdlabel = re.search('CDLABEL\=([a-zA-Z0-9_\.-]+)', cmdline.read()) > - cdlabel = cdlabel.group(0).split("=")[1] > - cmdline.close() > - for device in client.query_by_subsystem("block"): > - if device.has_property("ID_CDROM"): > - dev = device.get_property("DEVNAME") > - if system("blkid '%s'|grep -q '%s'" % (dev, cdlabel)): > - live_dev = dev > + cmdline_data = cmdline.read() > + cdlabel = re.search('CDLABEL\=([a-zA-Z0-9_\.-]+)', cmdline_data) > + if cdlabel is None: > + cdlabel = re.search('live\:([a-zA-Z0-9_\.-\/]+)', cmdline_data) > + live_dev = cdlabel.group(0).split(":")[1] > + else: > + cdlabel = cdlabel.group(0).split("=")[1] > + cmdline.close() > + for device in client.query_by_subsystem("block"): > + if device.has_property("ID_CDROM"): > + dev = device.get_property("DEVNAME") > + if system("blkid '%s'|grep -q '%s'" % (dev, cdlabel)): > + live_dev = dev > except: > pass > if not live_dev: > > bohai(ricky) > boh.ricky at gmail.com > > _______________________________________________ > node-devel mailing list > node-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/node-devel From bohai at huawei.com Fri Jun 21 09:03:28 2013 From: bohai at huawei.com (Bohai (ricky)) Date: Fri, 21 Jun 2013 09:03:28 +0000 Subject: [node-devel] support directly specify cdrom device to start livcd In-Reply-To: <1371800509.2619.12.camel@fdeutsch-laptop.local> References: <98B730463BF8F84A885ABF3A8F6149515775964E@szxeml523-mbx.china.huawei.com> <1371800509.2619.12.camel@fdeutsch-laptop.local> Message-ID: <98B730463BF8F84A885ABF3A8F614951577646E2@szxeml523-mbx.china.huawei.com> Hey fabian, > Could you push your patch (and the other one) to the ovirt-node project > on our gerrit instance (http://gerrit.ovirt.org)? > This wiki page explains how to work with gerrit: > http://www.ovirt.org/Working_with_oVirt_Gerrit OK. I will push that later. Best regard to you. ricky > -----Original Message----- > From: Fabian Deutsch [mailto:fabiand at redhat.com] > Sent: Friday, June 21, 2013 3:42 PM > To: Bohai (ricky) > Cc: node-devel at ovirt.org; Luohao (A); Haofeng > Subject: Re: [node-devel] support directly specify cdrom device to start livcd > > Hey Ricky, > > Am Freitag, den 21.06.2013, 04:05 +0000 schrieb Bohai (ricky): > > Now overt node only support to start livecd by specifing CDLABEL. > > Like this: > > root=live:CDLABEL=node-image > > > > But do not support to directly specify the cdrom device. > > Like this: > > root=live:/dev/sr0 > > > > This improve aims to support it. > > Thanks for the patch! That's probably something others are interested in > too. > Could you push your patch (and the other one) to the ovirt-node project > on our gerrit instance (http://gerrit.ovirt.org)? > This wiki page explains how to work with gerrit: > http://www.ovirt.org/Working_with_oVirt_Gerrit > > Thanks > fabian > > > > > > > diff --git a/src/ovirtnode/ovirtfunctions.py b/src/ovirtnode/ovirtfunctions.py > > index 4285757..4b27b68 100644 > > --- a/src/ovirtnode/ovirtfunctions.py > > +++ b/src/ovirtnode/ovirtfunctions.py > > @@ -465,14 +465,19 @@ def mount_live(): > > # /dev/live if not exist alternative > > client = gudev.Client(['block']) > > cmdline = open("/proc/cmdline") > > - cdlabel = re.search('CDLABEL\=([a-zA-Z0-9_\.-]+)', > cmdline.read()) > > - cdlabel = cdlabel.group(0).split("=")[1] > > - cmdline.close() > > - for device in client.query_by_subsystem("block"): > > - if device.has_property("ID_CDROM"): > > - dev = device.get_property("DEVNAME") > > - if system("blkid '%s'|grep -q '%s'" % (dev, > cdlabel)): > > - live_dev = dev > > + cmdline_data = cmdline.read() > > + cdlabel = re.search('CDLABEL\=([a-zA-Z0-9_\.-]+)', > cmdline_data) > > + if cdlabel is None: > > + cdlabel = re.search('live\:([a-zA-Z0-9_\.-\/]+)', > cmdline_data) > > + live_dev = cdlabel.group(0).split(":")[1] > > + else: > > + cdlabel = cdlabel.group(0).split("=")[1] > > + cmdline.close() > > + for device in client.query_by_subsystem("block"): > > + if device.has_property("ID_CDROM"): > > + dev = device.get_property("DEVNAME") > > + if system("blkid '%s'|grep -q '%s'" % (dev, > cdlabel)): > > + live_dev = dev > > except: > > pass > > if not live_dev: > > > > bohai(ricky) > > boh.ricky at gmail.com > > > > _______________________________________________ > > node-devel mailing list > > node-devel at ovirt.org > > http://lists.ovirt.org/mailman/listinfo/node-devel > From mburns at redhat.com Fri Jun 21 11:40:29 2013 From: mburns at redhat.com (Mike Burns) Date: Fri, 21 Jun 2013 07:40:29 -0400 Subject: [node-devel] Question about the plugins page in ovirt config In-Reply-To: <1371799906.2619.6.camel@fdeutsch-laptop.local> References: <98B730463BF8F84A885ABF3A8F6149515776454A@szxeml523-mbx.china.huawei.com> <1371799906.2619.6.camel@fdeutsch-laptop.local> Message-ID: <51C43BAD.3010302@redhat.com> On 06/21/2013 03:31 AM, Fabian Deutsch wrote: > Hey Bohai (or ricky?), > > Am Freitag, den 21.06.2013, 07:07 +0000 schrieb Bohai (ricky): >> I have some question about plugins page. >> First, it seem no any plugins. Where can i get some document about how to use the page? >> I hope to know how to install plugins for ovirt config? > > The feature page can be found here: > http://www.ovirt.org/Node_plugins > > Because edit-node changed a bit over time it could be that some commands > are outdate. > What kind of plugin do you want to install? These plugins are ovirt-node specific plugins. We will ship a couple for things like snmp and cim (previously included functionality that has been split out) as well as a couple new ones (puppet functionality) with our 3.0 release in a few weeks). > >> Two, I try to press button "RPM diff", "SRPM diff", "File diff". >> The program crashed for the reason "Keyerror(' plugin'). > > That could be a bug. > What version of oVirt Node are you using? > And could you attach /var/log/ovirt.log and /tmp/ovirt.debug.log This was a bug in the plugin page. It's fixed in the master branch now, but a build is not available yet. It's fixed with this patch: http://gerrit.ovirt.org/#/c/15732/ > >> Whether the feature is not finished now ?If so, can you tell me the plan about the feature. > > The plugin feature is now merged for some time and also used by us (e.g. > to add the plugin for test automation). > The UI for plugins is quite new and can still have some rough edges. > > Greetings > fabian > >> Best regard to you. >> >> bohai(ricky) >> boh.ricky at gmail.com >> >> >> _______________________________________________ >> node-devel mailing list >> node-devel at ovirt.org >> http://lists.ovirt.org/mailman/listinfo/node-devel > > _______________________________________________ > node-devel mailing list > node-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/node-devel > From bohai at huawei.com Sat Jun 22 09:07:59 2013 From: bohai at huawei.com (Bohai (ricky)) Date: Sat, 22 Jun 2013 09:07:59 +0000 Subject: [node-devel] Problem about modify admin's password on security page Message-ID: <98B730463BF8F84A885ABF3A8F6149515776545F@szxeml523-mbx.china.huawei.com> Hi, I found that ovirt-node doesn't support modifying admin account's password in security page and there were some discussion about it in https://bugzilla.redhat.com/show_bug.cgi?id=966354. I applied the patch and tested it again, but an error is thrown probably like this "list but not string". I found that the code "passwd.set_password("admin", pw)" in security_page.py caught this problem . Because pw was a list but not a string. So i suggest the following modification to solve this problem: Before: pw = effective_model.values_for(passwd_keys) After: pws = effective_model.values_for(passwd_keys) pw=pwTmp[0] Best regards to you. Ricky From fabiand at redhat.com Mon Jun 24 07:44:07 2013 From: fabiand at redhat.com (Fabian Deutsch) Date: Mon, 24 Jun 2013 09:44:07 +0200 Subject: [node-devel] Problem about modify admin's password on security page In-Reply-To: <98B730463BF8F84A885ABF3A8F6149515776545F@szxeml523-mbx.china.huawei.com> References: <98B730463BF8F84A885ABF3A8F6149515776545F@szxeml523-mbx.china.huawei.com> Message-ID: <1372059847.2522.0.camel@fdeutsch-laptop.local> Am Samstag, den 22.06.2013, 09:07 +0000 schrieb Bohai (ricky): > Hi, > > I found that ovirt-node doesn't support modifying admin account's password in security page and there were some discussion about it in https://bugzilla.redhat.com/show_bug.cgi?id=966354. > > I applied the patch and tested it again, but an error is thrown probably like this "list but not string". > > I found that the code "passwd.set_password("admin", pw)" in security_page.py caught this problem . Because pw was a list but not a string. > > So i suggest the following modification to solve this problem: > Before: > pw = effective_model.values_for(passwd_keys) > After: > pws = effective_model.values_for(passwd_keys) > pw=pwTmp[0] Hey Ricky, thanks - a good catch. I squashed this fix into the latest patchset of http://gerrit.ovirt.org/#/c/15079/ Greetings fabian From mburns at redhat.com Tue Jun 25 01:04:41 2013 From: mburns at redhat.com (Mike Burns) Date: Mon, 24 Jun 2013 21:04:41 -0400 Subject: [node-devel] pre-beta ovirt-node 3.0.0 images Message-ID: <51C8ECA9.9040600@redhat.com> Hi All, The initial images for oVirt Node 3.0.0 are now available on ovirt.org[1]. A list of the features included in this release is available on the oVirt Wiki[2]. Some notes: * Primary testing thus far has concentrated on the F18 based image. * An issue was found on the EL6 image on the Security page.[3] * EL6 image contains a newer than EL6 version of python-urwid. This is due to incompatibilities between the current version in EL6 and ovirt-node. * These images are *not* compatible with oVirt Engine at this time. A customized version should be available in the next few days. [1] http://resources.ovirt.org/releases/node-base/3.0.0/iso/ [2] http://www.ovirt.org/Node_3.0_release-management [3] This issue is the reason that we this is a pre-beta image From bohai at huawei.com Tue Jun 25 03:20:56 2013 From: bohai at huawei.com (Bohai (ricky)) Date: Tue, 25 Jun 2013 03:20:56 +0000 Subject: [node-devel] problem about ovirt-node-upgrade Message-ID: <98B730463BF8F84A885ABF3A8F6149515776736D@szxeml523-mbx.china.huawei.com> Hi, When I try to use ovirt-node-upgrade command, an error like below occurred. ----------------error message---------------------------------- virt-node-upgrade.UpgradeTool: WARNING Cleanup Failed WARNING:ovirt-node-upgrade.UpgradeTool:Cleanup Failed DEBUG:ovirt-node-upgrade.UpgradeTool:exception Traceback (most recent call last): File "/sbin/ovirt-node-upgrade", line 211, in _cleanup if os.path.exists(self.iso_tmp): File "/usr/lib64/python2.7/genericpath.py", line 18, in exists os.stat(path) TypeError: coercing to Unicode: need string or buffer, NoneType found ------------------------------------------------------------------------ I saw the code .The reason may be that self.iso_tmp is None sometimes. So I think it's better to confirm whether self.iso_tmp is None before run function " os.path.exists ". I try to fix it and test it. The command seem ok now. diff --git a/scripts/ovirt-node-upgrade.py b/scripts/ovirt-node-upgrade.py index ecd5be6..0503069 100755 --- a/scripts/ovirt-node-upgrade.py +++ b/scripts/ovirt-node-upgrade.py @@ -208,7 +208,7 @@ class UpgradeTool(Base): self._system(which("umount"), dir) os.remove(self._lock_file) shutil.rmtree(self._tmp_dir) - if os.path.exists(self.iso_tmp): + if self.iso_tmp and os.path.exists(self.iso_tmp): os.remove(self.iso_tmp) except: self._logger.warning("Cleanup Failed") Best regards to you. Ricky From hadong at redhat.com Tue Jun 25 04:14:31 2013 From: hadong at redhat.com (Haiyang Dong) Date: Tue, 25 Jun 2013 00:14:31 -0400 (EDT) Subject: [node-devel] problem about ovirt-node-upgrade In-Reply-To: <98B730463BF8F84A885ABF3A8F6149515776736D@szxeml523-mbx.china.huawei.com> References: <98B730463BF8F84A885ABF3A8F6149515776736D@szxeml523-mbx.china.huawei.com> Message-ID: <393846474.12032627.1372133671863.JavaMail.root@redhat.com> Hey Ricky, I have added your patch into the latest patchset of http://gerrit.ovirt.org/#/c/16054/ thanks, hadong ----- Original Message ----- From: "Bohai (ricky)" To: node-devel at ovirt.org Cc: "Luohao (A)" , "Haofeng" , "boh ricky" Sent: Tuesday, June 25, 2013 11:20:56 AM Subject: [node-devel] problem about ovirt-node-upgrade Hi, When I try to use ovirt-node-upgrade command, an error like below occurred. ----------------error message---------------------------------- virt-node-upgrade.UpgradeTool: WARNING Cleanup Failed WARNING:ovirt-node-upgrade.UpgradeTool:Cleanup Failed DEBUG:ovirt-node-upgrade.UpgradeTool:exception Traceback (most recent call last): File "/sbin/ovirt-node-upgrade", line 211, in _cleanup if os.path.exists(self.iso_tmp): File "/usr/lib64/python2.7/genericpath.py", line 18, in exists os.stat(path) TypeError: coercing to Unicode: need string or buffer, NoneType found ------------------------------------------------------------------------ I saw the code .The reason may be that self.iso_tmp is None sometimes. So I think it's better to confirm whether self.iso_tmp is None before run function " os.path.exists ". I try to fix it and test it. The command seem ok now. diff --git a/scripts/ovirt-node-upgrade.py b/scripts/ovirt-node-upgrade.py index ecd5be6..0503069 100755 --- a/scripts/ovirt-node-upgrade.py +++ b/scripts/ovirt-node-upgrade.py @@ -208,7 +208,7 @@ class UpgradeTool(Base): self._system(which("umount"), dir) os.remove(self._lock_file) shutil.rmtree(self._tmp_dir) - if os.path.exists(self.iso_tmp): + if self.iso_tmp and os.path.exists(self.iso_tmp): os.remove(self.iso_tmp) except: self._logger.warning("Cleanup Failed") Best regards to you. Ricky _______________________________________________ node-devel mailing list node-devel at ovirt.org http://lists.ovirt.org/mailman/listinfo/node-devel From mburns at redhat.com Tue Jun 25 14:33:32 2013 From: mburns at redhat.com (Mike Burns) Date: Tue, 25 Jun 2013 10:33:32 -0400 Subject: [node-devel] oVirt Node Weekly Meeting Minutes -- 2013-06-25 Message-ID: <51C9AA3C.9030506@redhat.com> Minutes: http://ovirt.org/meetings/ovirt/2013/ovirt.2013-06-25-14.00.html Minutes (text): http://ovirt.org/meetings/ovirt/2013/ovirt.2013-06-25-14.00.txt Log: http://ovirt.org/meetings/ovirt/2013/ovirt.2013-06-25-14.00.log.html ================================= #ovirt: oVirt Node Weekly Meeting ================================= Meeting started by mburns at 14:00:48 UTC. The full logs are available at http://ovirt.org/meetings/ovirt/2013/ovirt.2013-06-25-14.00.log.html . Meeting summary --------------- * Agenda (mburns, 14:01:00) * 3.0 status review (mburns, 14:01:08) * next steps (mburns, 14:01:24) * other topics (mburns, 14:01:26) * 3.0 status review (mburns, 14:01:38) * pre-beta images posted last night (mburns, 14:01:48) * some issues already found (mburns, 14:02:03) * some install issues on el6 (late breaking) (mburns, 14:02:49) * services don't start correctly on el6 (mburns, 14:03:05) * security screen broken on el6 (mburns, 14:03:14) * security page fix is posted and merged (mburns, 14:04:30) * patch pending for service startup issues (mburns, 14:05:22) * http://gerrit.ovirt.org/16080 (mburns, 14:05:26) * images are available for F18, F19, EL6 (mburns, 14:06:39) * also posted test packages for ovirt-node-plugin-vdsm (mburns, 14:07:18) * likely to be another build available either in the next day or so (mburns, 14:08:47) * couple edit-node patches pending -- jboggs to review this morning (mburns, 14:11:23) * need to review dependencies for -recipe and -tools rpms for el6 compatibility (mburns, 14:11:50) * next steps (mburns, 14:13:39) * next steps are to get these issues ironed out and merged (mburns, 14:13:51) * then get an official set of beta images posted (mburns, 14:14:06) * then test with the ovirt-node-vdsm-plugin packages for oVirt compatibility (mburns, 14:14:48) * Other Topics (mburns, 14:17:46) * was pinged earlier about including some newer versions of packages in ovirt.org repos (mburns, 14:18:08) * specifically things like libvirt (mburns, 14:18:25) * we can handle this in ovirt-node by simply adding the virt-preview repo (mburns, 14:20:06) * LINK: http://fedoraproject.org/wiki/Virtualization_Preview_Repository (mburns, 14:20:21) * ACTION: mburns to check with openstack folks on virt-preview repo (mburns, 14:30:34) * decision on whether to enable by default to come base on that discussion (mburns, 14:30:50) Meeting ended at 14:32:43 UTC. Action Items ------------ * mburns to check with openstack folks on virt-preview repo Action Items, by person ----------------------- * mburns * mburns to check with openstack folks on virt-preview repo * **UNASSIGNED** * (none) People Present (lines said) --------------------------- * mburns (72) * fabiand (27) * jboggs (6) * ovirtbot (4) * rbarry (2) * sgocken (1) Generated by `MeetBot`_ 0.1.4 .. _`MeetBot`: http://wiki.debian.org/MeetBot From bohai at huawei.com Wed Jun 26 08:06:14 2013 From: bohai at huawei.com (Bohai (ricky)) Date: Wed, 26 Jun 2013 08:06:14 +0000 Subject: [node-devel] a problem about security page in ovirt-node 3.0 Message-ID: <98B730463BF8F84A885ABF3A8F61495157768F93@szxeml523-mbx.china.huawei.com> Hi, I tried the newest ovirt-node 3.0. When I switch to the Security page ,the below exception occurred. I don't understand why. Any hint is welcome. [root at localhost ~]# ovirt-node-setup --debug Traceback (most recent call last): File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main "__main__", fname, loader, pkg_name) File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code exec code in run_globals File "/usr/lib/python2.7/site-packages/ovirt/node/setup/__main__.py", line 31, in app.run() File "/usr/lib/python2.7/site-packages/ovirt/node/app.py", line 303, in run self.ui.run() File "/usr/lib/python2.7/site-packages/ovirt/node/ui/urwid_builder.py", line 473, in run self.__loop.run() File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 271, in run self.screen.run_wrapper(self._run) File "/usr/lib64/python2.7/site-packages/urwid/raw_display.py", line 241, in run_wrapper return fn() File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 336, in _run self.event_loop.run() File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 707, in run self._loop() File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 777, in _loop self._entering_idle() File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 696, in _entering_idle callback() File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 548, in entering_idle self.draw_screen() File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 562, in draw_screen canvas = self._topmost_widget.render(self.screen_size, focus=True) File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render canv = fn(self, size, focus=focus) File "/usr/lib64/python2.7/site-packages/urwid/decoration.py", line 224, in render canv = self._original_widget.render(size, focus=focus) File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render canv = fn(self, size, focus=focus) File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1057, in render focus and self.focus_part == 'body') File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render canv = fn(self, size, focus=focus) File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1498, in render canv = w.render((maxcol, rows), focus=focus and item_focus) File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render canv = fn(self, size, focus=focus) File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 2054, in render focus = focus and self.focus_position == i) File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render canv = fn(self, size, focus=focus) File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1057, in render focus and self.focus_part == 'body') File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render canv = fn(self, size, focus=focus) File "/usr/lib64/python2.7/site-packages/urwid/decoration.py", line 563, in render canv = self._original_widget.render((maxcol,)+size[1:], focus) File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render canv = fn(self, size, focus=focus) File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1498, in render canv = w.render((maxcol, rows), focus=focus and item_focus) File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render canv = fn(self, size, focus=focus) File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 1750, in render canv = get_delegate(self).render(size, focus=focus) File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render canv = fn(self, size, focus=focus) File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1498, in render canv = w.render((maxcol, rows), focus=focus and item_focus) File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render canv = fn(self, size, focus=focus) File "/usr/lib64/python2.7/site-packages/urwid/decoration.py", line 563, in render canv = self._original_widget.render((maxcol,)+size[1:], focus) File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render canv = fn(self, size, focus=focus) File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1057, in render focus and self.focus_part == 'body') File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render canv = fn(self, size, focus=focus) File "/usr/lib64/python2.7/site-packages/urwid/decoration.py", line 224, in render canv = self._original_widget.render(size, focus=focus) File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render canv = fn(self, size, focus=focus) File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1492, in render canv = w.render((maxcol,), focus=focus and item_focus) File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render canv = fn(self, size, focus=focus) File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1492, in render canv = w.render((maxcol,), focus=focus and item_focus) File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render canv = fn(self, size, focus=focus) File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 787, in render maxcol, maxrow = size ValueError: need more than 1 value to unpack Best regards to you. Ricky From bohai at huawei.com Wed Jun 26 08:08:09 2013 From: bohai at huawei.com (Bohai (ricky)) Date: Wed, 26 Jun 2013 08:08:09 +0000 Subject: [node-devel] a problem about 3.0 ovirt-node's performance page Message-ID: <98B730463BF8F84A885ABF3A8F61495157768FAC@szxeml523-mbx.china.huawei.com> Hi, When I use the newest ovirt-node, the below exception occurred when I switch to the Performance page. I read the code and try to fix it. It seems ok now. diff --git a/src/ovirt/node/utils/tuned.py b/src/ovirt/node/utils/tuned.py index 4be10fa..1d7a3b5 100644 --- a/src/ovirt/node/utils/tuned.py +++ b/src/ovirt/node/utils/tuned.py @@ -48,9 +48,9 @@ def get_active_profile(): """ try: profile = process.check_output("/usr/sbin/tuned-adm active") + return re.match(r'.*?: (.*)', profile).group(1) except: return "None" - return re.match(r'.*?: (.*)', profile).group(1) def set_active_profile(profile): ------------------------------detail debug log-------------------------------------------------------------------------- [root at localhost ~]# ovirt-node-setup --debug Traceback (most recent call last): File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main "__main__", fname, loader, pkg_name) File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code exec code in run_globals File "/usr/lib/python2.7/site-packages/ovirt/node/setup/__main__.py", line 31, in app.run() File "/usr/lib/python2.7/site-packages/ovirt/node/app.py", line 303, in run self.ui.run() File "/usr/lib/python2.7/site-packages/ovirt/node/ui/urwid_builder.py", line 473, in run self.__loop.run() File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 271, in run self.screen.run_wrapper(self._run) File "/usr/lib64/python2.7/site-packages/urwid/raw_display.py", line 241, in run_wrapper return fn() File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 336, in _run self.event_loop.run() File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 707, in run self._loop() File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 786, in _loop self._watch_files[fd]() File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 387, in _update self.process_input(keys) File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 487, in process_input k = self._topmost_widget.keypress(self.screen_size, k) File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1102, in keypress return self.body.keypress( (maxcol, remaining), key ) File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1559, in keypress key = self.focus.keypress(tsize, key) File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 2240, in keypress key = w.keypress((mc,) + size[1:], key) File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1559, in keypress key = self.focus.keypress(tsize, key) File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 2240, in keypress key = w.keypress((mc,) + size[1:], key) File "/usr/lib64/python2.7/site-packages/urwid/listbox.py", line 1000, in keypress return actual_key(self._keypress_down((maxcol, maxrow))) File "/usr/lib64/python2.7/site-packages/urwid/listbox.py", line 1108, in _keypress_down row_offset, 'above') File "/usr/lib64/python2.7/site-packages/urwid/listbox.py", line 842, in change_focus self.body.set_focus(position) File "/usr/lib64/python2.7/site-packages/urwid/listbox.py", line 179, in set_focus self._modified() File "/usr/lib64/python2.7/site-packages/urwid/listbox.py", line 159, in _modified ListWalker._modified(self) File "/usr/lib64/python2.7/site-packages/urwid/listbox.py", line 41, in _modified signals.emit_signal(self, "modified") File "/usr/lib64/python2.7/site-packages/urwid/signals.py", line 120, in emit result |= bool(callback(*args_copy)) File "/usr/lib/python2.7/site-packages/ovirt/node/ui/widgets.py", line 334, in __on_item_change urwid.emit_signal(self, "changed", plugin) File "/usr/lib64/python2.7/site-packages/urwid/signals.py", line 120, in emit result |= bool(callback(*args_copy)) File "/usr/lib/python2.7/site-packages/ovirt/node/ui/urwid_builder.py", line 524, in menu_item_changed self.application.switch_to_plugin(plugin) File "/usr/lib/python2.7/site-packages/ovirt/node/app.py", line 266, in switch_to_plugin self.show(content) File "/usr/lib/python2.7/site-packages/ovirt/node/app.py", line 276, in show self.populate_with_values(ui_container) File "/usr/lib/python2.7/site-packages/ovirt/node/app.py", line 247, in populate_with_values model = self.current_plugin().model() File "/usr/lib/python2.7/site-packages/ovirt/node/setup/core/performance_page.py", line 40, in model profile = tuned.get_active_profile() File "/usr/lib/python2.7/site-packages/ovirt/node/utils/tuned.py", line 53, in get_active_profile return re.match(r'.*?: (.*)', profile).group(1) AttributeError: 'NoneType' object has no attribute 'group' Best regards to you. Ricky From fabiand at redhat.com Wed Jun 26 09:26:16 2013 From: fabiand at redhat.com (Fabian Deutsch) Date: Wed, 26 Jun 2013 11:26:16 +0200 Subject: [node-devel] a problem about security page in ovirt-node 3.0 In-Reply-To: <98B730463BF8F84A885ABF3A8F61495157768F93@szxeml523-mbx.china.huawei.com> References: <98B730463BF8F84A885ABF3A8F61495157768F93@szxeml523-mbx.china.huawei.com> Message-ID: <1372238776.6422.0.camel@fdeutsch-laptop.local> Am Mittwoch, den 26.06.2013, 08:06 +0000 schrieb Bohai (ricky): > Hi, > > I tried the newest ovirt-node 3.0. When I switch to the Security page ,the below exception occurred. > I don't understand why. Any hint is welcome. Hey Ricky, yes, we are aware of this problem. A fix for this bug is already posted: http://gerrit.ovirt.org/16074 Greetings fabian > [root at localhost ~]# ovirt-node-setup --debug > > Traceback (most recent call last): > File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main > "__main__", fname, loader, pkg_name) > File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code > exec code in run_globals > File "/usr/lib/python2.7/site-packages/ovirt/node/setup/__main__.py", line 31, in > app.run() > File "/usr/lib/python2.7/site-packages/ovirt/node/app.py", line 303, in run > self.ui.run() > File "/usr/lib/python2.7/site-packages/ovirt/node/ui/urwid_builder.py", line 473, in run > self.__loop.run() > File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 271, in run > self.screen.run_wrapper(self._run) > File "/usr/lib64/python2.7/site-packages/urwid/raw_display.py", line 241, in run_wrapper > return fn() > File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 336, in _run > self.event_loop.run() > File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 707, in run > self._loop() > File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 777, in _loop > self._entering_idle() > File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 696, in _entering_idle > callback() > File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 548, in entering_idle > self.draw_screen() > File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 562, in draw_screen > canvas = self._topmost_widget.render(self.screen_size, focus=True) > File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render > canv = fn(self, size, focus=focus) > File "/usr/lib64/python2.7/site-packages/urwid/decoration.py", line 224, in render > canv = self._original_widget.render(size, focus=focus) > File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render > canv = fn(self, size, focus=focus) > File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1057, in render > focus and self.focus_part == 'body') > File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render > canv = fn(self, size, focus=focus) > File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1498, in render > canv = w.render((maxcol, rows), focus=focus and item_focus) > File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render > canv = fn(self, size, focus=focus) > File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 2054, in render > focus = focus and self.focus_position == i) > File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render > canv = fn(self, size, focus=focus) > File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1057, in render > focus and self.focus_part == 'body') > File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render > canv = fn(self, size, focus=focus) > File "/usr/lib64/python2.7/site-packages/urwid/decoration.py", line 563, in render > canv = self._original_widget.render((maxcol,)+size[1:], focus) > File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render > canv = fn(self, size, focus=focus) > File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1498, in render > canv = w.render((maxcol, rows), focus=focus and item_focus) > File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render > canv = fn(self, size, focus=focus) > File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 1750, in render > canv = get_delegate(self).render(size, focus=focus) > File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render > canv = fn(self, size, focus=focus) > File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1498, in render > canv = w.render((maxcol, rows), focus=focus and item_focus) > File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render > canv = fn(self, size, focus=focus) > File "/usr/lib64/python2.7/site-packages/urwid/decoration.py", line 563, in render > canv = self._original_widget.render((maxcol,)+size[1:], focus) > File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render > canv = fn(self, size, focus=focus) > File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1057, in render > focus and self.focus_part == 'body') > File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render > canv = fn(self, size, focus=focus) > File "/usr/lib64/python2.7/site-packages/urwid/decoration.py", line 224, in render > canv = self._original_widget.render(size, focus=focus) > File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render > canv = fn(self, size, focus=focus) > File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1492, in render > canv = w.render((maxcol,), focus=focus and item_focus) > File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render > canv = fn(self, size, focus=focus) > File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1492, in render > canv = w.render((maxcol,), focus=focus and item_focus) > File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 140, in cached_render > canv = fn(self, size, focus=focus) > File "/usr/lib64/python2.7/site-packages/urwid/widget.py", line 787, in render > maxcol, maxrow = size > ValueError: need more than 1 value to unpack > > > Best regards to you. > Ricky > > _______________________________________________ > node-devel mailing list > node-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/node-devel From fabiand at redhat.com Wed Jun 26 09:27:06 2013 From: fabiand at redhat.com (Fabian Deutsch) Date: Wed, 26 Jun 2013 11:27:06 +0200 Subject: [node-devel] a problem about 3.0 ovirt-node's performance page In-Reply-To: <98B730463BF8F84A885ABF3A8F61495157768FAC@szxeml523-mbx.china.huawei.com> References: <98B730463BF8F84A885ABF3A8F61495157768FAC@szxeml523-mbx.china.huawei.com> Message-ID: <1372238826.6422.1.camel@fdeutsch-laptop.local> Am Mittwoch, den 26.06.2013, 08:08 +0000 schrieb Bohai (ricky): > Hi, > > When I use the newest ovirt-node, the below exception occurred when I switch to the Performance page. > I read the code and try to fix it. It seems ok now. Good catch, that's also new code. Could you create an account in gerrit and post the patch there? Thanks fabian > diff --git a/src/ovirt/node/utils/tuned.py b/src/ovirt/node/utils/tuned.py > index 4be10fa..1d7a3b5 100644 > --- a/src/ovirt/node/utils/tuned.py > +++ b/src/ovirt/node/utils/tuned.py > @@ -48,9 +48,9 @@ def get_active_profile(): > """ > try: > profile = process.check_output("/usr/sbin/tuned-adm active") > + return re.match(r'.*?: (.*)', profile).group(1) > except: > return "None" > - return re.match(r'.*?: (.*)', profile).group(1) > > > def set_active_profile(profile): > > > ------------------------------detail debug log-------------------------------------------------------------------------- > [root at localhost ~]# ovirt-node-setup --debug > > Traceback (most recent call last): > File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main > "__main__", fname, loader, pkg_name) > File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code > exec code in run_globals > File "/usr/lib/python2.7/site-packages/ovirt/node/setup/__main__.py", line 31, in > app.run() > File "/usr/lib/python2.7/site-packages/ovirt/node/app.py", line 303, in run > self.ui.run() > File "/usr/lib/python2.7/site-packages/ovirt/node/ui/urwid_builder.py", line 473, in run > self.__loop.run() > File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 271, in run > self.screen.run_wrapper(self._run) > File "/usr/lib64/python2.7/site-packages/urwid/raw_display.py", line 241, in run_wrapper > return fn() > File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 336, in _run > self.event_loop.run() > File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 707, in run > self._loop() > File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 786, in _loop > self._watch_files[fd]() > File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 387, in _update > self.process_input(keys) > File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 487, in process_input > k = self._topmost_widget.keypress(self.screen_size, k) > File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1102, in keypress > return self.body.keypress( (maxcol, remaining), key ) > File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1559, in keypress > key = self.focus.keypress(tsize, key) > File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 2240, in keypress > key = w.keypress((mc,) + size[1:], key) > File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1559, in keypress > key = self.focus.keypress(tsize, key) > File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 2240, in keypress > key = w.keypress((mc,) + size[1:], key) > File "/usr/lib64/python2.7/site-packages/urwid/listbox.py", line 1000, in keypress > return actual_key(self._keypress_down((maxcol, maxrow))) > File "/usr/lib64/python2.7/site-packages/urwid/listbox.py", line 1108, in _keypress_down > row_offset, 'above') > File "/usr/lib64/python2.7/site-packages/urwid/listbox.py", line 842, in change_focus > self.body.set_focus(position) > File "/usr/lib64/python2.7/site-packages/urwid/listbox.py", line 179, in set_focus > self._modified() > File "/usr/lib64/python2.7/site-packages/urwid/listbox.py", line 159, in _modified > ListWalker._modified(self) > File "/usr/lib64/python2.7/site-packages/urwid/listbox.py", line 41, in _modified > signals.emit_signal(self, "modified") > File "/usr/lib64/python2.7/site-packages/urwid/signals.py", line 120, in emit > result |= bool(callback(*args_copy)) > File "/usr/lib/python2.7/site-packages/ovirt/node/ui/widgets.py", line 334, in __on_item_change > urwid.emit_signal(self, "changed", plugin) > File "/usr/lib64/python2.7/site-packages/urwid/signals.py", line 120, in emit > result |= bool(callback(*args_copy)) > File "/usr/lib/python2.7/site-packages/ovirt/node/ui/urwid_builder.py", line 524, in menu_item_changed > self.application.switch_to_plugin(plugin) > File "/usr/lib/python2.7/site-packages/ovirt/node/app.py", line 266, in switch_to_plugin > self.show(content) > File "/usr/lib/python2.7/site-packages/ovirt/node/app.py", line 276, in show > self.populate_with_values(ui_container) > File "/usr/lib/python2.7/site-packages/ovirt/node/app.py", line 247, in populate_with_values > model = self.current_plugin().model() > File "/usr/lib/python2.7/site-packages/ovirt/node/setup/core/performance_page.py", line 40, in model > profile = tuned.get_active_profile() > File "/usr/lib/python2.7/site-packages/ovirt/node/utils/tuned.py", line 53, in get_active_profile > return re.match(r'.*?: (.*)', profile).group(1) > AttributeError: 'NoneType' object has no attribute 'group' > > Best regards to you. > Ricky > > _______________________________________________ > node-devel mailing list > node-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/node-devel From bohai at huawei.com Fri Jun 21 08:39:55 2013 From: bohai at huawei.com (Bohai (ricky)) Date: Fri, 21 Jun 2013 08:39:55 +0000 Subject: [node-devel] =?utf-8?b?562U5aSNOiAgZml4IG5vIGtleSAiT1ZJUlRfQk9P?= =?utf-8?q?TPARAMS=22_problem_occured_in_ovirt-node=27s_install?= In-Reply-To: <1371799998.2619.8.camel@fdeutsch-laptop.local> References: <98B730463BF8F84A885ABF3A8F6149515776446A@szxeml523-mbx.china.huawei.com> <1371799998.2619.8.camel@fdeutsch-laptop.local> Message-ID: <98B730463BF8F84A885ABF3A8F614951577646AF@szxeml523-mbx.china.huawei.com> Hi, Fabian Thank you for your time. > -----????----- > ???: Fabian Deutsch [mailto:fabiand at redhat.com] > ????: 2013?6?21? 15:33 > ???: Bohai (ricky) > ??: node-devel at ovirt.org; Luohao (A); Haofeng > ??: Re: [node-devel] fix no key "OVIRT_BOOTPARAMS" problem occured in > ovirt-node's install > > Hey Bohai (or ricky?), > This is ricky :) > Am Freitag, den 21.06.2013, 06:37 +0000 schrieb Bohai (ricky): > > I found the "No key" exception occurred in overt-node's install progress. > > For the detail, please see the attached picture. > > The patch below looks quite okay, but could you also explain what you > did to run into this problem? The kernel arguments and installation > method would be interesting. About installation 1. make the iso of ovirt-node. 2. I install the ovirt node to the machine through the Baseboard Management Controller. So attach the iso to the machine like attached file "install.png". 3. Reset the machine and install the ovirt node. About the kernel arguments, Please see the attached file "parameter.png". Thanks. ricky > > Thanks > fabian > > > This patch fixs the problem. > > > > I am a newbie for ovirt-node and I apologize if I am missing something very > obvious. > > Any advice is welcomed. > > > > > > diff --git a/src/ovirtnode/install.py b/src/ovirtnode/install.py > > index 7b95b04..eae26ba 100755 > > --- a/src/ovirtnode/install.py > > +++ b/src/ovirtnode/install.py > > @@ -475,7 +475,8 @@ initrd /initrd0.img > > else: > > self.root_param = "root=live:LABEL=Root" > > self.bootparams = "ro rootfstype=auto rootflags=ro " > > - self.bootparams += OVIRT_VARS["OVIRT_BOOTPARAMS"].replace( > > + > > + self.bootparams += OVIRT_VARS.get("OVIRT_BOOTPARAMS", > "").replace( > > > "console=tty0", "") > > if " " in self.disk or os.path.exists("/dev/cciss"): > > # workaround for grub setup failing with spaces in dev.name: > > > > bohai(ricky) > > boh.ricky at gmail.com > > > > > > _______________________________________________ > > node-devel mailing list > > node-devel at ovirt.org > > http://lists.ovirt.org/mailman/listinfo/node-devel > -------------- next part -------------- A non-text attachment was scrubbed... Name: parameter.png Type: image/png Size: 7001 bytes Desc: parameter.png URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: install.png Type: image/png Size: 28900 bytes Desc: install.png URL: From bohai at huawei.com Fri Jun 21 09:27:03 2013 From: bohai at huawei.com (Bohai (ricky)) Date: Fri, 21 Jun 2013 09:27:03 +0000 Subject: [node-devel] Question about the plugins page in ovirt config In-Reply-To: <1371799906.2619.6.camel@fdeutsch-laptop.local> References: <98B730463BF8F84A885ABF3A8F6149515776454A@szxeml523-mbx.china.huawei.com> <1371799906.2619.6.camel@fdeutsch-laptop.local> Message-ID: <98B730463BF8F84A885ABF3A8F61495157764797@szxeml523-mbx.china.huawei.com> Hey Fabian, > -----Original Message----- > From: Fabian Deutsch [mailto:fabiand at redhat.com] > Sent: Friday, June 21, 2013 3:32 PM > To: Bohai (ricky) > Cc: node-devel at ovirt.org; dhuff at redhat.com; Luohao (A); Haofeng > Subject: Re: [node-devel] Question about the plugins page in ovirt config > > Hey Bohai (or ricky?), > > Am Freitag, den 21.06.2013, 07:07 +0000 schrieb Bohai (ricky): > > I have some question about plugins page. > > First, it seem no any plugins. Where can i get some document about how to > use the page? > > I hope to know how to install plugins for ovirt config? > > The feature page can be found here: > http://www.ovirt.org/Node_plugins > Thank you. I will learn it. > Because edit-node changed a bit over time it could be that some commands > are outdate. > What kind of plugin do you want to install? > I am just trying to use and learn the feature now. > > Two, I try to press button "RPM diff", "SRPM diff", "File diff". > > The program crashed for the reason "Keyerror(' plugin'). > > That could be a bug. > What version of oVirt Node are you using? > And could you attach /var/log/ovirt.log and /tmp/ovirt.debug.log > I use the master branch of ovirt-node git repo to build the ISO. The below is the commit number. Almost the newest I think. commit ed00633d0890f592b70bb73a0ee65774d5162847 About the log ,please see the attach file. > > Whether the feature is not finished now ?If so, can you tell me the plan about > the feature. > > The plugin feature is now merged for some time and also used by us (e.g. > to add the plugin for test automation). > The UI for plugins is quite new and can still have some rough edges. > OK. Thanks for your time and your answer. Ricky. > Greetings > fabian > > > Best regard to you. > > > > bohai(ricky) > > boh.ricky at gmail.com > > > > > > _______________________________________________ > > node-devel mailing list > > node-devel at ovirt.org > > http://lists.ovirt.org/mailman/listinfo/node-devel -------------- next part -------------- A non-text attachment was scrubbed... Name: ovirt_node_log.zip Type: application/x-zip-compressed Size: 85094 bytes Desc: ovirt_node_log.zip URL: From bohai at huawei.com Tue Jun 25 10:44:07 2013 From: bohai at huawei.com (Bohai (ricky)) Date: Tue, 25 Jun 2013 10:44:07 +0000 Subject: [node-devel] A suggestion about Network page Message-ID: <98B730463BF8F84A885ABF3A8F614951577676EE@szxeml523-mbx.china.huawei.com> Hi, I used bmc(board management controller) to remotely access the server machine and the below is the screenshot. Please look at the red rectangle area where the mac address is in a new line. Whether it's better to refine it and support automatically adapt to different console. [cid:_1_07E722C407E71834003A0A0548257B95] ricky -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: ATT00001.gif Type: image/gif Size: 38008 bytes Desc: ATT00001.gif URL: From fabiand at redhat.com Thu Jun 27 10:12:11 2013 From: fabiand at redhat.com (Fabian Deutsch) Date: Thu, 27 Jun 2013 12:12:11 +0200 Subject: [node-devel] A suggestion about Network page In-Reply-To: <98B730463BF8F84A885ABF3A8F614951577676EE@szxeml523-mbx.china.huawei.com> References: <98B730463BF8F84A885ABF3A8F614951577676EE@szxeml523-mbx.china.huawei.com> Message-ID: <1372327931.3026.2.camel@fdeutsch-laptop.local> Am Dienstag, den 25.06.2013, 10:44 +0000 schrieb Bohai (ricky): > Hi, > I used bmc(board management controller) to remotely access the server > machine and the below is the screenshot. > > Please look at the red rectangle area where the mac address is in a > new line. > > Whether it?s better to refine it and support automatically adapt to > different console. Hey Ricky, I know that this problem was around a couple of days ago. We assume a minimum size of 80x24 and all elements should fit on such a screen size, what you are seeing is a bug and should be fixed. But IIRC it has been fixed. Greetings fabian