[node-patches] Change in ovirt-node[master]: add in missing appvg creation from bash storage scripts

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: add in missing appvg creation from bash storage scripts
......................................................................


Patch Set 1: Fails; I would prefer that you didn't submit this

(4 inline comments)

See inline comments.  Most are nitpicks, but handling around -1 for DATA2 isn't right.

....................................................
File scripts/storage.py
Line 424:         logger.info(self.DATA2_SIZE)
Seems like this should be debug level and perhaps provide more detail than just the value of the variables.

Line 472:         if self.DATA2_SIZE == 1:
Using remaining free space is determined with -1 not 1

Line 482:             system("mke2fs -j -t ext4 /dev/AppVG/Data2 -L \"DATA\"")
shouldn't it be mke2fs ... -L "DATA2" ?

Line 485:         if use_data == 0:
Why have this if again?  doesn't the previous if statement cover it?

--
To view, visit http://gerrit.ovirt.org/170
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d7c97b00ea10382bca1894e172958447a9b1aee
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>