[node-patches] Change in ovirt-node[master]: BZ#815825 validate vdsmcert against cacert

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: BZ#815825 validate vdsmcert against cacert
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(5 inline comments)

....................................................
File libvirtd.upstart
Line 10:     DATE="$(date +%Y-%m-%d_%H%M%S)"
is this used anywhere?

Line 11:     ret=`openssl verify -CAfile /etc/pki/vdsm/certs/cacert.pem /etc/pki/vdsm/certs/vdsmcert.pem`
should use $(...) syntax

Line 14:         do
for file in ${PATH_CERT}/*; do

Line 16:             if [[ $ret == "/etc/pki/vdsm/certs/vdsmcert.pem: OK" ]]; then
use $(...) syntax instead of ``

don't use [[ ]] if you can avoid it

Line 23:                 break
please use {} around all variables

--
To view, visit http://gerrit.ovirt.org/3885
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d9de5d131fdaca0f875b14d21a97943c63b1770
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>