[node-patches] Change in ovirt-node[master]: split proxy server:port for rhn conf

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: split proxy server:port for rhn conf
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

see inline -- feel free to correct me if i'm wrong, but it's how it looks to me

....................................................
File scripts/rhn.py
Line 499:             p_server, p_port = self.rv("httpProxy").split(":")
Line 500:             self.proxyhost.set(p_server)
Line 501:             self.proxyport.set(p_port)
Line 502:         except:
Line 503:             pass
what about proxyuser and proxypass?  why are we dropping those?

shouldn't we also handle if the port isn't passed?  

it appears to me that:

1.  we're no longer setting self.proxy{user,pass}
2.  if proxyhost is passed as http://proxy.example.com, then we're also not setting self.proxyhost
Line 504:         self.rhn_actkey = Entry(40, "")
Line 505:         if rhn_check():
Line 506:             if self.rhn_url.value() == ("https://xmlrpc.rhn.redhat.com/XMLRPC"
Line 507:                                         or len(self.rhn_url.value()) == 0):


--
To view, visit http://gerrit.ovirt.org/7519
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id826af6b75f6348254e6b4910351ae8fb625d38f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>