[node-patches] Change in ovirt-node[master]: Add archipel option with stateless boot

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: Add archipel option with stateless boot
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(11 inline comments)

See multiple in-line comments.  Overall pretty good, but some things definitely need to be tweaked a bit.

....................................................
File .gitignore
Line 22: scripts/collectd.conf
NACK -- none of these should be in .gitignore

....................................................
File ovirt-node.spec.in
Line 135: %endif
There are equivalent blocks like this throughout this file where you add && ! 0%{?centos} then immediately follow with:

if 0%{?centos}

and do the same thing as before.  If centos really shows up as RHEL (and I don't know if it does), then this should just be a single block.  You should only need separate blocks if rhel and centos truly do different things.

....................................................
File recipe/archipel-install.ks
Line 1: selinux --permissive
NACK

Please get selinux fixed or add a policy module and remove setting it to permissive

....................................................
File recipe/archipel-node-image.ks.in
Line 1: # Archipel Node image recipe
This is probably OK, but it would make more sense to me to incorporate this stuff into the base ovirt-node-image.ks.in instead and have the --with-archipel stuff handle the changes

Line 27: # %include common-manifest.ks
You should probably uncomment this line to get manifests included.  I understand removing them for development purposes, but probably a good idea to have them in general.

....................................................
File recipe/archipel-post.ks
Line 6:    /etc/sysconfig/libvirtd
in general, it's better to use augeas to set things like this where possible

Line 66:     chkconfig --add ovirt-post
not sure what you're trying to accomplish here.  is this a change we should be making in general?

....................................................
File recipe/centos6-pkgs.ks
Line 2: virt-who
probably doesn't apply to centos

....................................................
File recipe/common-install.ks
Line 8: part / --size 2048 --fstype ext2
need to figure out if this is really necessary.  I don't want to double the size if I can avoid it.

....................................................
File recipe/rhevh6-pkgs.ks
Line 16: vdsm-reg
need ltrace, vhostmd here too

....................................................
File scripts/ovirt-auto-install.py
Line 30: from ovirt_config_setup.collectd import *
Overall, probably OK, but we really should re-examine this and clean it up.

--
To view, visit http://gerrit.ovirt.org/1738
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0754395652d015bd5b835b8c13c14bad17aef6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Antoine Mercadal <antoine.mercadal at inframonde.eu>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>