[node-patches] Change in ovirt-node[master]: last uefi temp workaround for working installation

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: last uefi temp workaround for working installation
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

See Comments

....................................................
File scripts/install.py
Line 321:         self.bootparams = self.bootparams.replace("nomodeset","")
you're removing nomodeset for all boots if I'm reading this right.  If that's the case, this should be done in common-nochroot.ks, not here.  also, removing the quiet option above seems to already be in common-nochroot.ks

Line 402:                 system("cp -a /tmp/EFI /liveos/efi")
add a comment here that this is a hack that we shouldn't have to do and reference a bz for kernel or dmm if one exists

--
To view, visit http://gerrit.ovirt.org/1176
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55b562049241856857bd78c61950182bb29d9538
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>