[node-patches] Change in ovirt-node[master]: Adjust python code style to pep 8 (http://www.python.org/dev...

ewoud at kohlvanwijngaarden.nl ewoud at kohlvanwijngaarden.nl
Mon Jul 2 13:56:31 UTC 2012


Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Adjust python code style to pep 8 (http://www.python.org/dev/peps/pep-0008/)
......................................................................


Patch Set 2: (1 inline comment)

For pep8 patches it is useful if you include the pydiff output. See https://fedorahosted.org/pipermail/vdsm-devel/2012-June/001054.html for more info.

....................................................
Commit Message
Line 7: Adjust python code style to pep 8 (http://www.python.org/dev/peps/pep-0008/)
The first line of a commit message is usually under 50 chars. See http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

--
To view, visit http://gerrit.ovirt.org/3896
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd60913950fea456210114e1d859f6d638803397
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Eli Qiao <qiaoliyong at gmail.com>
Gerrit-Reviewer: Eli Qiao <qiaoliyong at gmail.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list