[node-patches] Change in ovirt-node[master]: move validate_dup_files to more reusable function to validat...

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: move validate_dup_files to more reusable function to validate plugin installs
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

One minor comment

....................................................
File tools/edit-node
Line 911:                     if not dir in line and i <= len(valid_write_locations):
dir in line could be replaced with line.startswith(dir) - this would make it more safe

--
To view, visit http://gerrit.ovirt.org/5795
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b92512cc824a386c9537a043ca1338fae945e9c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>