[node-patches] Change in ovirt-node[master]: Adjust python code style to pep 8 (http://www.python.org/dev...

fabiand at fedoraproject.org fabiand at fedoraproject.org
Tue Jul 3 08:52:38 UTC 2012


Fabian Deutsch has posted comments on this change.

Change subject: Adjust python code style to pep 8 (http://www.python.org/dev/peps/pep-0008/)
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

The start looks good, but there are still quite many pep8 violations (~12).
Did you run the file thorugh "pep8 -r scripts/ovirt-auto-install.py"
Part of fedoras python-pep8 package.

....................................................
File scripts/ovirt-auto-install.py
Line 71:                "no")
there is one whitespace missing before the "no" for a correct indentation

--
To view, visit http://gerrit.ovirt.org/4136
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibba77af68d68201eb40fa7afd3cf7dcf2a12363f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Eli Qiao <qiaoliyong at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list