[node-patches] Change in ovirt-node[master]: network.py: Fix syntax to be pep8 conform

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: network.py: Fix syntax to be pep8 conform
......................................................................


Patch Set 2: Do not submit

(2 inline comments)

two syntax errors

....................................................
File scripts/network.py
Line 142:                 if "OVIRT_IP_NETMASK" iOVIRT_VARS:
s/iOVIRT_VARS/in OVIRT_VARS/

Line 399:                                      "{'print $3'}" % pci_dev)
this fails, there are more brackets needed:
((" lspci|grep %s|awk -F \":\" " +
  "{'print $3'}") % pci_dev)

(The string needs to be grouped, before the values are assigned by the % op)

--
To view, visit http://gerrit.ovirt.org/3329
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib595a7a8d4bb910b377eaad56847b738a83ba125
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>