[node-patches] Change in ovirt-node[master]: storage.py: fix to conform to pep8 standard

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: storage.py: fix to conform to pep8 standard
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(6 inline comments)

Some format string problems

....................................................
File scripts/storage.py
Line 174:                       "2>/dev/null | sort -u" % (dev, dev, part_delim))
concatenated format strings needs to be group with (…) otherwise % would just affect the last string part

Line 186:                                  "disks." % vg)
sames as above

Line 212:                              "secs" % (timeout - i))
same as above

Line 291:                           "sed -r 's/^.*(dm-[0-9]+ ).*$/\\1/'" % (d, d))
same as above

Line 691:                         self.LABEL_TYPE)
I'd indent this to match the self.BOOTDRIVE indentation

Line 697:                           "512M\"" % self.BOOTDRIVE)
concatenated format strings need to be grouped by (…)

--
To view, visit http://gerrit.ovirt.org/3326
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2d28a4fb82b68bb188061a8209dab53caf496af
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>