[node-patches] Change in ovirt-node[master]: Remove redunent code in ovirt-functions

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Remove redunent code in ovirt-functions
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

IIUIC this bash script isn't used anymore, because it was ported to python. There is also an inline comment regarding the functionality

....................................................
Commit Message
Line 9: The "$1" only is a parameter not a parameter list. So here "for" loop
$1 can be a list of $SEP (,) separated devices, IFS is set to $SEP, therefor it would loop through this list.
Try: 
$ A="a,b,c" IFS="," ; for X in $A ; do echo $X ; done

AFAIK this bash based variant isn't used anymore anyway.
Do you know about it's usage Mike?

--
To view, visit http://gerrit.ovirt.org/6138
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5335938acad861b555f64ea0ab50daffcb64f5d4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>