[node-patches] Change in ovirt-node[master]: edit-node update BOOTX64.conf root= value when editing iso

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: edit-node update BOOTX64.conf root= value when editing iso
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File tools/edit-node
Line 528:         efiargs.append('s/root=[^ ]*/root=live:CDLABEL=' + self.name[:32] + '/')
is it save to use this array slice? (name[:32])
Might a regex be safer?

Line 536:                              stdout = subprocess.PIPE,
no spaces used around the = operator when it's used in keyword args (afaik)

--
To view, visit http://gerrit.ovirt.org/6162
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I456ad2906f089a1aa345de7cdbdc2ece0662372e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>