[node-patches] Change in ovirt-node[master]: installer: Add Caps Lock hint

mburns at redhat.com mburns at redhat.com
Wed Jul 18 19:17:51 UTC 2012


Michael Burns has posted comments on this change.

Change subject: installer: Add Caps Lock hint
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File scripts/ovirtfunctions.py
Line 1386:                                        stderr=STDOUT).stdout.read().strip()
on a standard console, i get the following out: 

# setleds < /dev/tty0
Current default flags:  NumLock off   CapsLock off   ScrollLock off
Current flags:          NumLock off   CapsLock off   ScrollLock off
Current leds:           NumLock off   CapsLock off   ScrollLock off

We should be looking at current flags, i think.


Also,  on a serial console, I this doesn't seem to work

# LC_ALL=C setleds < /dev/ttyS0
KDGKBLED: Invalid argument
Error reading current flags setting. Maybe you are not on the console?

--
To view, visit http://gerrit.ovirt.org/6430
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id18a3cc7c51ed500c029df03d19c0f78cb8d0790
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>



More information about the node-patches mailing list