[node-patches] Change in ovirt-node[master]: installer: Add Caps Lock hint

fabiand at fedoraproject.org fabiand at fedoraproject.org
Thu Jul 19 14:48:31 UTC 2012


Fabian Deutsch has posted comments on this change.

Change subject: installer: Add Caps Lock hint
......................................................................


Patch Set 6: (2 inline comments)

....................................................
File scripts/ovirtfunctions.py
Line 1394:         return None
An alternative is to throw an exception like raise Exception("CapsLock state can not be determined on a serial console."), which is the caught in the pw check cb.

Line 1397:                                        stderr=STDOUT).stdout.read().strip()
it actually filters out the flags line and returns the 6th token, so this should match the capslock state

--
To view, visit http://gerrit.ovirt.org/6430
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id18a3cc7c51ed500c029df03d19c0f78cb8d0790
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>



More information about the node-patches mailing list