[node-patches] Change in ovirt-node[master]: ovirtfunctions: Make sure we don't kill ourselves.

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: ovirtfunctions: Make sure we don't kill ourselves.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

Thanks for the patch Eli.

One inline comment, otherwise a good catch and did you run into this problem?

....................................................
File scripts/ovirtfunctions.py
Line 519:                 if pid != os.getpid():
pid will be a string, getpid returns an int, so the comparison will always be true (as pid and os.getpid() are always unequal )
Maybe int(pid) != os.getpid() works.

--
To view, visit http://gerrit.ovirt.org/6559
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib057e0576661137928d0d717dbc302314f4bea32
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Eli Qiao <taget at linux.vnet.ibm.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>