[node-patches] Change in ovirt-node[master]: install: fix KeyError on no-efi machine

fabiand at fedoraproject.org fabiand at fedoraproject.org
Mon Jul 30 06:47:59 UTC 2012


Fabian Deutsch has posted comments on this change.

Change subject: install: fix KeyError on no-efi machine
......................................................................


Patch Set 1: (1 inline comment)

Hey,
thanks for your patch.

I've got one minor inline comment.

....................................................
File scripts/install.py
Line 126:                 GRUB_CONFIG_TEMPLATE = """
I'd rather add the efi-only line using a condition to the default GRUBCONFIG_TEMPLATE defined above, this way just one default template needs updated.

--
To view, visit http://gerrit.ovirt.org/6688
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecd523776f6eb5fa534ca3234363210e7b09bdc9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Jarod.w <work.iec23801 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Jarod.w <work.iec23801 at gmail.com>



More information about the node-patches mailing list