[node-patches] Change in ovirt-node[master]: fix check for kvm support

fabiand at fedoraproject.org fabiand at fedoraproject.org
Thu Jun 21 16:38:13 UTC 2012


Fabian Deutsch has posted comments on this change.

Change subject: fix check for kvm support
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File scripts/ovirt-init-functions.sh
Line 1242:         if [ -e /dev/kvm ] && lsmod | egrep -q "kvm_intel|kvm_amd"; then
What about using [[ - saves us a fork()
functionally fine

--
To view, visit http://gerrit.ovirt.org/5366
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4656b82639999e0328d63a37cef09097b287bdb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list