[node-patches] Change in ovirt-node[master]: dracut: check if all PVs are given in the storage_init param...

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: dracut: check if all PVs are given in the storage_init parameter, if not, exit installation.
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(4 inline comments)

The patch looks good, I just had a couple of non-critical nit picks.

....................................................
Commit Message
Line 9:         rhbz 816216 lvm dracut part removes VGs uncompromising
Would be nice to use rhbz#816216 so this can be picked up by some scripts

....................................................
File dracut/ovirt-cleanup.sh
Line 90:             for ipv in $(lvm vgs --noheadings -o pv_name $vg 2>/dev/null); do 
trailing white-space

Line 97:                 done
IFS should be reset to previous IFS

Line 100:                     return 0  
trailing white-space

--
To view, visit http://gerrit.ovirt.org/5756
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia478c8dbbd76be4b7e1f1dac829cfabd53b57bc6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Eli Qiao <taget at linux.vnet.ibm.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>