[node-patches] Change in ovirt-node[master]: add man page for node-creator

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: add man page for node-creator
......................................................................


Patch Set 2: Fails; I would prefer that you didn't submit this

(5 inline comments)

Thanks for the patch, just a few nit picks now that I've actually looked at it.

1.  It's part of the wrong rpm.  node-creator is part of ovirt-node-recipe, so the man page has to be part of ovirt-node-recipe.  See in line comments for when to add it.

2.  BREW_TARGET command shouldn't be documented in upstream.  It really shouldn't even exist upstream, but I'll take a separate action to remove it.

Thanks

....................................................
File ovirt-node.spec.in
Line 224: %defattr(0755,root,root,0755)
should have man page here.

Line 309: %{_mandir}/man8/node-creator.8.gz
not here.

Line 313: - add man page for node-creator
please drop changelog

....................................................
File recipe/node-creator.8
Line 7: node-creator [<RECIPE> [<BREW_TARGET>]]
Don't mention BREW_TARGET here, it's not applicable upstream.

Line 12: BREW\_TARGET \- Brew build target e.g. rhev-h-5E-build
drop this line, BREW_TARGET is not applicable upstream.

--
To view, visit http://gerrit.ovirt.org/5739
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I708ebbdfd22adee585ed78b8011507dc534546ef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Eli Qiao <taget at linux.vnet.ibm.com>
Gerrit-Reviewer: Eli Qiao <taget at linux.vnet.ibm.com>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>