[node-patches] Change in ovirt-node[master]: cim: Only set password if it meets requirements

mburns at redhat.com mburns at redhat.com
Fri Jun 29 13:30:50 UTC 2012


Michael Burns has posted comments on this change.

Change subject: cim: Only set password if it meets requirements
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

Nit pick, but functionally works.

....................................................
File scripts/cim.py
Line 113:             msg = "CIM Password Is Invalid"
It would be better if we could have a better reason here.  password_check sets msg to a better reason.  Perhaps we could use that reason instead, and set it to "CIM Password is invalid" if we don't have a reason.

--
To view, visit http://gerrit.ovirt.org/5745
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f954640c4061c68e4bde5c15d1a6ac61c4fa471
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>



More information about the node-patches mailing list