[node-patches] Change in ovirt-node[master]: snmp: Check password confirmation

mburns at redhat.com mburns at redhat.com
Fri Jun 29 14:21:44 UTC 2012


Michael Burns has posted comments on this change.

Change subject: snmp: Check password confirmation
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)

Functionally it works, just some nits with the popup message and commit message

....................................................
Commit Message
Line 7: snmp: Check password confirmation
some information here would be good

Previously, it was possible to set the password even if the passwords did not match.  Now, changing/setting the password will check that the password validations were correct.

....................................................
File scripts/ovirt-config-setup.py
Line 1612:                       ButtonChoiceWindow(self.screen, "SNMP", "SNMP Was Not Enabled Because Passwords Do Not Match", buttons = ['Ok'])
Let's not use title case.

SNMP was not enabled because passwords do not match

--
To view, visit http://gerrit.ovirt.org/5746
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e8d908a7f97d01ae79261b839c2a997a35da898
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>



More information about the node-patches mailing list