[node-patches] Change in ovirt-node[master]: add initial plugin tool

mburns at redhat.com mburns at redhat.com
Thu Mar 22 16:02:28 UTC 2012


Michael Burns has posted comments on this change.

Change subject: add initial plugin tool
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

using the tools directory is fine, but we shouldn't include the existing scripts that are there.  You might want to consider either a new directory called plugins instead.

....................................................
File tools/Makefile.am
Line 24:   edit-node
we're not shipping or using these other scripts.  No need to include them in the EXTRA_DIST anymore.

--
To view, visit http://gerrit.ovirt.org/2179
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66d57ebd7efaaecc38ed0719e4f6c1cc76bfc550
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>



More information about the node-patches mailing list