[node-patches] Change in ovirt-node[master]: add support for ssh key injection to edit-node

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: add support for ssh key injection to edit-node
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File tools/edit-node
Line 73:                     print "Invalid Key File: %s" % key
Need to validate the user name provided and either fail or default to admin if not found.  I'd probably default to admin.  Maybe add an additional option called -u or --user that is a comma separated list of users to apply key files to.  All key files would then be applied to all users in the list.  

Another option would be to change the delimiter from _ to something like : or ! which aren't in the default id_rsa.pub filename.  And default to admin if that delimiter is not found.

What I see happening here is that the user will create an id_rsa.pub and go to upload it.  They'll end up with /home/id/.ssh/authorized_keys instead of having the key added to admin

--
To view, visit http://gerrit.ovirt.org/2970
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634ac6cd7f028c86c968d1731fa77f0a41c87fdc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>