[node-patches] Change in ovirt-node[master]: add initial plugin tool

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: add initial plugin tool
......................................................................


Patch Set 3: (3 inline comments)

....................................................
File tools/edit-node
Line 69:         edit_args="edit-livecd -s %s %s" % (scriptfile, self.args)
can we generate a log file?

Line 73:             print "\n\nEdited ISO is: " + self.args + "edited.iso\n"
maybe delete log file and script file if not requested.  User could possibly request the logfile with another option.  If too much for this patch, feel free to file a bz and fix in the future.

If logfile not specified, then create log in /tmp and clean up if run passes.

Line 76:             print "Editing Failed"
maybe show the script file generated and the log file

--
To view, visit http://gerrit.ovirt.org/2179
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66d57ebd7efaaecc38ed0719e4f6c1cc76bfc550
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>