[node-patches] Change in ovirt-node[master]: add snmp password length check for < 8

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: add snmp password length check for < 8
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

I'd vote for pulling the password check into the password_check() function. Maybe with a default value of 3 or so.
Or zero to provide b/c. (If the length wasn't checked before and people might be using very short or no password)

....................................................
File scripts/ovirt-config-setup.py
Line 481:               if len(self.root_password_1.value()) < 8:
I'd say this should go into password_check().

--
To view, visit http://gerrit.ovirt.org/3889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a66093565ef061c895318d4f76f2a13f4b99a9a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>