[node-patches] Change in ovirt-node[master]: mount only files and directories listed in /etc/files

[danken at redhat.com]

Dan Kenigsberg has posted comments on this change.

Change subject: mount only files and directories listed in /etc/files
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File scripts/ovirt-functions.in
Line 382:             cp -rv --update /live/config/* /config
Line 383:         fi
Line 384:         # bind mount all persisted configs to rootfs
Line 385:         for f in $(cat /config/files); do
Line 386:             if grep -q " $f ext[234]" /proc/mounts ; then
It can wait for another patch, but this (and the former code) would blow up if the "$f" has spaces in it, since they show up as \040 in /proc/mounts.

I suppose that newlines need treatment when reading /config/files elsewhere, too.

I personally do not care, as I'm sane enough to use only printable filenames.
Line 387:                 # skip if already bind-mounted
Line 388:                 true
Line 389:             else
Line 390:                 mkdir -p "$(dirname "$f")"


--
To view, visit http://gerrit.ovirt.org/8317
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6dce8d619b8a6a51d636974eb34141f8aac9bae7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Alan Pevec <apevec at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>