[node-patches] Change in ovirt-node[master]: network: Create non-default rules file for NICs

[jboggs at redhat.com]

Joey Boggs has posted comments on this change.

Change subject: network: Create non-default rules file for NICs
......................................................................


Patch Set 2: Fails

(1 inline comment)

traceback error due to missing _functions otherwise ack

....................................................
File scripts/ovirtnode/network.py
Line 367:         _functions.ovirt_store_config("/etc/hosts")
Line 368: 
Line 369:         # Copy the initial net rules to a file that get's not
Line 370:         # overwritten at each boot, rhbz#773495
Line 371:         system_closefds("cp /etc/udev/rules.d/70-persistent-net.rules" +
just needs _functions in front of  system_closefds
Line 372:                         " /etc/udev/rules.d/71-persistent-node-net.rules" +
Line 373:                         " >> /var/log/ovirt.log");
Line 374:         _functions.ovirt_store_config("/etc/udev/rules.d/" +
Line 375:                                       "71-persistent-node-net.rules")


--
To view, visit http://gerrit.ovirt.org/8352
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5fb9787275a85bd1c3052a50debc0c6397345f32
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>