[node-patches] Change in ovirt-node[master]: setup: check bridge bootproto instead of device when renamed

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: setup: check bridge bootproto instead of device when renamed
......................................................................


Patch Set 1: (1 inline comment)

looks fine...but see inline before pushing

....................................................
File scripts/ovirt-config-setup.py
Line 1064:                 dev_bridge) = self.nic_dict[dev].split(",", 6)
Line 1065:         if dev_bridge == "rhevm" or dev_bridge == "ovirtmgmt":
Line 1066:             cmd = ("/files/etc/sysconfig/network-scripts/" + \
Line 1067:                    "ifcfg-%s/BOOTPROTO" % dev_bridge)
Line 1068:             bootproto = augtool_get(cmd)
why only rhevm or ovirtmgmt?  shouldn't we read the bridge device for all devices if it's defined?
Line 1069:         nic_detail_grid = Grid(6, 10)
Line 1070:         nic_detail_grid.setField(Label("Interface:   "), 0, 1, anchorLeft=1,
Line 1071:                                  padding=(0, 0, 1, 0))
Line 1072:         nic_detail_grid.setField(Label("Protocol:    "), 0, 2, anchorLeft=1,


--
To view, visit http://gerrit.ovirt.org/8475
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I710ae355bad1c71ae7f9a3bf35d6e9c741b5c5ed
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>