[node-patches] Change in ovirt-node[master]: [DRAFT] boot: Persist NIC order at boot time

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: [DRAFT] boot: Persist NIC order at boot time
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

overall, I like the change if you address the 1 inline comment.  

Feel free to argue if you disagree with the inline comment.

....................................................
File scripts/ovirt-init-functions.sh
Line 825:             hostname $HOSTNAME
Line 826:         fi
Line 827:     fi
Line 828: 
Line 829:     persist_nic_order
I think this is the wrong place.

Think about the initial boot when nothing is installed, which is the case you're trying to solve.

Boot runs, hit's ovirt-early where this runs.  
it tries to persist, but there is no persistent storage (yet).

Probably best to add the file either to the list in ovirt-functions (OVIRT_CONFIG_FILES) or to the ovirt_store_firstboot_config function.
Line 830:     # Now that the order is (eventually) persisted, apply it.
Line 831:     [[ -f "/etc/udev/rules.d/71-persistent-node-net.rules" ]] && {
Line 832:         # Rename the interfaces after bind-mounting the udev rules, rhbz#831658
Line 833:         rm -f /etc/udev/rules.d/70-persistent-net.rules


--
To view, visit http://gerrit.ovirt.org/8497
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a5d830c0664264fc67ce7270c284ddc5551c3c8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>