[node-patches] Change in ovirt-node[master]: kdump: verify ssh connection setup successfully before finis...

[jboggs at redhat.com]

Joey Boggs has uploaded a new change for review.

Change subject: kdump: verify ssh connection setup successfully before finishing configuration
......................................................................

kdump: verify ssh connection setup successfully before finishing configuration

rhbz#869513

Change-Id: I9329dc1564967c1caf8ffc355953d54324684ba0
Signed-off-by: Joey Boggs <jboggs at redhat.com>
---
M scripts/ovirt-config-setup.py
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/91/8791/1

diff --git a/scripts/ovirt-config-setup.py b/scripts/ovirt-config-setup.py
index 1180bf2..51216df 100755
--- a/scripts/ovirt-config-setup.py
+++ b/scripts/ovirt-config-setup.py
@@ -1813,6 +1813,7 @@
         return
 
     def process_kdump_config(self):
+        ret = 0
         if os.path.exists("/etc/kdump.conf"):
             system("cp /etc/kdump.conf /etc/kdump.conf.old")
         if self.kdump_nfs_type.value() == 1:
@@ -1826,7 +1827,8 @@
                 kdump_prop_cmd = "kdumpctl propagate"
             else:
                 kdump_prop_cmd = "service kdump propagate"
-            ret = system_closefds("clear; %s" % kdump_prop_cmd)
+            propagate_proc = passthrough("clean; %s" % kdump_prop_cmd, logger.debug)
+            ret = propagate_proc.retval
             if ret == 0:
                 ovirt_store_config("/root/.ssh/kdump_id_rsa.pub")
                 ovirt_store_config("/root/.ssh/kdump_id_rsa")
@@ -1836,7 +1838,7 @@
             restore_kdump_config()
         else:
             return
-        if not system("service kdump restart"):
+        if not system("service kdump restart") or ret > 0:
             self._create_warn_screen()
             ButtonChoiceWindow(self.screen, "KDump Status",
                                "KDump configuration failed, " +


--
To view, visit http://gerrit.ovirt.org/8791
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9329dc1564967c1caf8ffc355953d54324684ba0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>