[node-patches] Change in ovirt-node[master]: handle log_size set to 0

jboggs at redhat.com jboggs at redhat.com
Thu Oct 25 14:13:42 UTC 2012


Joey Boggs has posted comments on this change.

Change subject: handle log_size set to 0
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

just swap config->logging and ack

....................................................
File scripts/ovirt-config-installer.py
Line 254:             self.log_vol_failed = True
Line 255:             self.log_vol_msg = "Logging Partition Size must be a positive integer."
Line 256:         elif int(self.LOGGING_SIZE.value()) < int(Storage.MIN_LOGGING_SIZE):
Line 257:             self.log_vol_failed = True
Line 258:             self.log_vol_msg = "Minimum Config size is %s MB." % Storage.MIN_LOGGING_SIZE
change config to Logging and ack
Line 259:         else:
Line 260:             self.log_vol_failed = False
Line 261:             self.log_vol_msg = None
Line 262:         self.write_storage_vol_msg()


--
To view, visit http://gerrit.ovirt.org/8676
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0fb03b2a55d8dedb2181267ee4380aa5fdc391c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>



More information about the node-patches mailing list