[node-patches] Change in ovirt-node[master]: don't show invalid popup when kdump fields are empty

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: don't show invalid popup when kdump fields are empty
......................................................................


Patch Set 1: Fails

(1 inline comment)

....................................................
File scripts/ovirt-config-setup.py
Line 573:                                        _snack.FLAGS_RESET)
Line 574:         self.kdump_ssh_config.setFlags(_snack.FLAG_DISABLED, _snack.FLAGS_SET)
Line 575: 
Line 576:     def kdump_valid_nfs_callback(self):
Line 577:         if not self.kdump_nfs_config.value() is None:
bah, thought i had uploaded and updated one already...

was going to compare to "", but i think i like len(<>) better.
Line 578:             if not is_valid_nfs(self.kdump_nfs_config.value()):
Line 579:                 self._create_warn_screen()
Line 580:                 ButtonChoiceWindow(self.screen, "Configuration Check",
Line 581:                                    "Invalid NFS Entry", buttons=['Ok'])


--
To view, visit http://gerrit.ovirt.org/8679
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22dd6c2d9db342b42c255c046285965c05ba1702
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>