[node-patches] Change in ovirt-node[master]: dont allow local kdump setting to be disabled without ssh/nf...

jboggs at redhat.com jboggs at redhat.com
Mon Oct 29 21:04:49 UTC 2012


Joey Boggs has uploaded a new change for review.

Change subject: dont allow local kdump setting to be disabled without ssh/nfs being available
......................................................................

dont allow local kdump setting to be disabled without ssh/nfs being available

rhbz#869927

Signed-off-by: Joey Boggs <jboggs at redhat.com>
Change-Id: Ia8744881fb25bda1dbeec4a2c9aa0ed7a4258ff1
---
M scripts/ovirt-config-setup.py
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/18/8918/1

diff --git a/scripts/ovirt-config-setup.py b/scripts/ovirt-config-setup.py
index c903c63..af0f4b7 100755
--- a/scripts/ovirt-config-setup.py
+++ b/scripts/ovirt-config-setup.py
@@ -601,8 +601,11 @@
     def kdump_restore_callback(self):
         self.kdump_ssh_type.setValue(" 0")
         self.kdump_nfs_type.setValue(" 0")
-        self.kdump_nfs_config.setFlags(_snack.FLAG_DISABLED, _snack.FLAGS_SET)
-        self.kdump_ssh_config.setFlags(_snack.FLAG_DISABLED, _snack.FLAGS_SET)
+        if self.kdump_restore_type.value() == 1:
+            self.kdump_nfs_config.setFlags(_snack.FLAG_DISABLED, _snack.FLAGS_SET)
+            self.kdump_ssh_config.setFlags(_snack.FLAG_DISABLED, _snack.FLAGS_SET)
+        if self.kdump_ssh_type.value() == 0 and self.kdump_nfs_type.value() == 0:
+            self.kdump_restore_type.setValue("*")
 
     def valid_netconsole_server_callback(self):
         if not is_valid_host_or_ip(self.netconsole_server.value()):


--
To view, visit http://gerrit.ovirt.org/8918
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8744881fb25bda1dbeec4a2c9aa0ed7a4258ff1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>



More information about the node-patches mailing list